Dynamically update base image to specific architecture #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
reviewed
Sep 27, 2022
| ifeq ($(ARCH),ppc64le) | ||
| BASEIMAGE ?= baseosscr.azurecr.io/build-image/distroless-iptables-ppc64le:v0.1.2 | ||
| endif | ||
| ifeq ($(ARCH),s390x) |
There was a problem hiding this comment.
💡🙏☕️ thank you so much for adding to the review. just idea share but all this could be single if we use: ifneq - we can check the list Params and just supply in ARCH value into baselImage.
Rest looks good if it works for you. 🎉☕️
Example here: https://stackoverflow.com/a/27335439
There was a problem hiding this comment.
Great suggestion! Going to hold off on this for now, as trying to get a new release out asap for arm64 support with distroless-iptables.
chengliangli0918
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous update to distroless base image was not compatible with all architectures.
In https://github.com/kubernetes/release/tree/master/images/build/distroless-iptables they publish for each architecture. However,
staging-k8s.gcr.iois not publicly accessible. Ran the samemake all-pushbut pointing at a AKS base image CR 'baseosscr.azurecr.io' which can be pulled from anywhere.