Install azure-cli with pip #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing it with apt-get was causing issues when running some commands that need uamqp library. Note that since the python docker image already has `setuptools== 58.1.0`, we needed to downgrade to a version < 58.0.0 to make it compatible with azure-cli==2.25.0 (compatible with azure-cli-core==2.25.0 pinned in this project). See related [issue](Azure/azure-cli#19468).
marianan
reviewed
Apr 25, 2022
| @@ -58,6 +51,10 @@ RUN \ | |||
| rm -rf /tmp/* && \ | |||
| rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| # Install azure-cli | |||
| RUN pip install setuptools==57.0.0 \ | |||
There was a problem hiding this comment.
It is true that az cli installs setuptools==52.0.0 (requirements.txt). However, we still need to make sure that the version of setuptools is <58.0.0 before installing az cli because of the following:
- The installation of python3.9 includes a newer version of setuptools (incompatible with az cli 2.25.0);
- az cli has a dependency on
pygithub==1.38, which may get installed beforesetuptoolsis downgraded to 52.0.0 (please note that there's no way to specify the order of installation with pip); - this version of
pygithub==1.38needs setuptools <58.0.0 because of a deprecated feature (see code).
Ideally, we should be using newer versions of az cli, but azure-cli-core is pinned to 2.25.0 (see code).
There was a problem hiding this comment.
I'd recommend to use a newer version of az cli instead of trying to account for deprecated lib versions.
There was a problem hiding this comment.
Yes, that would be ideal, but as mentioned, iotedgedev pins azure-cli-core to 2.25.0 (see code), which means that the version of az-cli installed via pip needs to be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing it with apt-get was causing issues when running some commands
that need uamqp library.
Note that since the python docker image already has
setuptools== 58.1.0,we needed to downgrade to a version < 58.0.0 to make it compatible with
azure-cli==2.25.0 (compatible with azure-cli-core==2.25.0 pinned
in this project). See related issue.
iotedgedev Pull Request Checklist
Additional comments