Add support to Quickstart for testing devices behind an HTTP proxy. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds two new CLI parameters `--proxy` and `--upstream-protocol`. They correspond to `agent.env.https_proxy` and `agent.env.UpstreamProtocol` in config.yaml. `--proxy` defaults to the `https_proxy` environment variable on the `Quickstart` process itself, if it's set. Also fixed JSON errors in the smoke test deployment templates that caused `jq` to choke.
1665f59 to
19a172e
Compare
|
|
myagley
approved these changes
Oct 17, 2018
| @@ -26,6 +26,6 @@ public Task ProcessEventsAsync(IEnumerable<EventData> events) | |||
| return Task.CompletedTask; | |||
| } | |||
| public Task ProcessErrorAsync(Exception error) => throw error; | |||
| public int MaxBatchSize { get; } = 10; | |||
| public int MaxBatchSize { get; set; } | |||
There was a problem hiding this comment.
The interface requires it.
There was a problem hiding this comment.
There doesn't seem to be any reason why they changed it to require a setter. The IPartitionReceiver impl in the SDK only gets its value.
damonbarry
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two new CLI parameters
--proxyand--upstream-protocol.They correspond to
agent.env.https_proxyandagent.env.UpstreamProtocolin config.yaml.
--proxydefaults to thehttps_proxyenvironment variable on theQuickstartprocess itself, if it's set.Also fixed JSON errors in the smoke test deployment templates that caused
jqto choke.