Option.Some method should not allow null value #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsing
reviewed
Oct 16, 2018
myagley
requested changes
Oct 16, 2018
|
Show the possible issue in IoTHubReporterTest.ReportShutdown test to @varunpuranik; and he said that fix in test should be good enough for now. Please kindly help to review again. |
…iotedge into phlin/fixOptionValidation
varunpuranik
previously approved these changes
Oct 16, 2018
arsing
previously approved these changes
Oct 16, 2018
myagley
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add validation to ensure null should not be allowed when calling Option.Some method.