Fix workspace manifest to use E2021 resolver. #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While individual crates default to resolver v2 if they are E2021, workspaces are virtual manifests with no edition so they continue to default to resolver v1. cargo raises a warning about this but only sometimes, so this wasn't easily noticeable. This change fixes the workspace manifest to use resolver v2.
damonbarry
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While individual crates default to resolver v2 if they are E2021, workspaces are virtual manifests with no edition so they continue to default to resolver v1. cargo raises a warning about this but only sometimes, so this wasn't easily noticeable.
This change fixes the workspace manifest to use resolver v2.