Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefer_module_identity_cache option #543

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Conversation

gordonwang0
Copy link
Contributor

@gordonwang0 gordonwang0 commented Aug 16, 2023

Adds the prefer_module_identity_cache (defaults to false) option in identityd's configuration.

Current behavior is to request module identities from IoT Hub and fall back to a cached backup if the Hub request fails. This keeps identities in sync with IoT Hub, but results in extra requests to Hub that may not be necessary depending on use case.

Setting prefer_module_identity_cache to true reverses the behavior so that the cached identities are preferred to IoT Hub requests. Requests to Hub are still made if identities are not found in the cache.

@gordonwang0 gordonwang0 requested a review from arsing August 16, 2023 18:55
@kodiakhq kodiakhq bot merged commit 61f903b into Azure:main Aug 16, 2023
kodiakhq bot pushed a commit to Azure/iotedge that referenced this pull request Aug 16, 2023
gordonwang0 added a commit to gordonwang0/iot-identity-service that referenced this pull request Aug 22, 2023
Adds the prefer_module_identity_cache (defaults to false) option in identityd's configuration.

Current behavior is to request module identities from IoT Hub and fall back to a cached backup if the Hub request fails. This keeps identities in sync with IoT Hub, but results in extra requests to Hub that may not be necessary depending on use case.

Setting prefer_module_identity_cache to true reverses the behavior so that the cached identities are preferred to IoT Hub requests. Requests to Hub are still made if identities are not found in the cache.
kodiakhq bot pushed a commit that referenced this pull request Sep 14, 2023
Adds the prefer_module_identity_cache (defaults to false) option in identityd's configuration.

Current behavior is to request module identities from IoT Hub and fall back to a cached backup if the Hub request fails. This keeps identities in sync with IoT Hub, but results in extra requests to Hub that may not be necessary depending on use case.

Setting prefer_module_identity_cache to true reverses the behavior so that the cached identities are preferred to IoT Hub requests. Requests to Hub are still made if identities are not found in the cache.
gordonwang0 added a commit to gordonwang0/iotedge that referenced this pull request Sep 14, 2023
kodiakhq bot pushed a commit to Azure/iotedge that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants