Propagate managedBy #507
Draft
Propagate managedBy #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanzebra
commented
Feb 3, 2023
| @@ -148,7 +149,7 @@ impl IdentityManager { | |||
| x509_thumbprint: None, | |||
| type_: Some(aziot_identity_common::hub::AuthType::Sas), | |||
| }), | |||
| None, | |||
| Some("Gordon".to_string()), | |||
There was a problem hiding this comment.
whoops, change to propagated one!
nyanzebra
commented
Feb 3, 2023
Comment on lines
969
to
987
| let hub_module_ids_and_managed_bys: std::collections::HashMap< | ||
| String, | ||
| Option<String>, | ||
| > = hub_module_ids | ||
| .into_iter() | ||
| .filter_map(|i| { | ||
| if let aziot_identity_common::Identity::Aziot(i) = i { | ||
| if let Some(module_id) = &i.module_id { | ||
| Some((module_id.0.clone(), i.managed_by.clone())) | ||
| } else { | ||
| None | ||
| } | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .collect(); | ||
|
|
||
| let mut module_set = vec![]; |
There was a problem hiding this comment.
Uncertain on what is 'right' here
nyanzebra
commented
Feb 3, 2023
Comment on lines
970
to
971
| String, | ||
| Option<String>, |
nyanzebra
commented
Feb 3, 2023
|
|
||
| for (module_id, managed_by) in module_set { | ||
| // TODO: do we need to take previous identity and pass along? | ||
| self.create_module_identity(&module_id.0, managed_by.clone()) |
There was a problem hiding this comment.
Can just put None here, only host-level mods are affected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.