-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate catch2 v2 to v3 #683
base: develop
Are you sure you want to change the base?
Migrate catch2 v2 to v3 #683
Conversation
@AndreRicardo-Zoetis please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Hello, would you consider upgrading Catch to version 3?
We would like to use newer functionality in Catch2 such as SKIP.
https://catch2-temp.readthedocs.io/en/latest/skipping-passing-failing.html
Also noticed that in Catch2 version 3 there is no need to define all those empty
main.cpp
.Changes
Followed the guidelines from:
https://catch2-temp.readthedocs.io/en/latest/migrate-v2-to-v3.html
Change Catch2 to Catch2WithMain where
main.cpp
was used[!hide]
tag has been removedhttps://github.com/catchorg/Catch2/blob/914aeecfe23b1e16af6ea675a4fb5dbd5a5b8d0a/docs/release-notes.md?plain=1#L505
"The
Contains
string matcher was renamed toContainsSubstring
."https://github.com/catchorg/Catch2/blob/devel/docs/migrate-v2-to-v3.md#things-that-can-break-during-porting
I can tidy up the PR further and remove all the no longer needed
main.cpp
files, but before doing so would like to have your guidance.PS: I do have other changes to be able to run the tests as GitHub Action but was able to run the tests successfully in
https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/12689720900/job/35369056358