Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file download error in Ubuntu Core agent #675

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

Nox-MSFT
Copy link
Contributor

@Nox-MSFT Nox-MSFT commented Dec 5, 2024

Delivery Optimization Agent Snap expect the target file path to be begins with /var/lib/deviceupdate-agent-downloads.
This is fix by allowing customer to specify the ADUC_ConfigInfo.downloadsFolder in du-config.json.
By override the default downloads folder, the ADUC_FileEntity.TargetFileName will begins with the specified value (in Ubuntu Core, it must be /var/lib/deviceupdate-agent-downloads)

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 suggestion.

Files not reviewed (3)
  • src/agent/adu_core_interface/src/adu_core_interface.c: Language not supported
  • src/utils/config_utils/src/config_utils.c: Language not supported
  • src/utils/config_utils/tests/config_utils_ut.cpp: Language not supported

snap/local/README.md Outdated Show resolved Hide resolved
@Nox-MSFT Nox-MSFT requested review from jw-msft and a team December 5, 2024 23:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

// NOTE: Ensure that the downloadsFolder is set correctly, if specified in du-configjson.
// (Instead of a 'downloads' sub-folder of the dataFolder )
SECTION("Ubunto Core DO downlad.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: downlad

Copy link
Contributor

@nihemstr nihemstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Nox-MSFT Nox-MSFT merged commit 1efcc99 into feature/snap-1 Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants