Fix installs-deps -a catch2 issue on ubuntu 20.04 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option error -Wcomma-subscript
shiyi-peng
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building catch2 from sources fails on
#pragma GCC diagnostic ignored "-Wcomma-subscript"due to using gcc-9 and g++-9 packages on Ubuntu 20.04This change installs gcc-10 and g++-10 packages on Ubuntu 20.04 to resolve this and also exports CC and CXX env variables so that catch2 CMake build will use gcc-10 and g++-10 instead of gcc-9 and g++-9.