Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CreateTaskOrchestrationAsync tp throw OrchestrationAlreadyExistsException #1060

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Apr 5, 2024

This is to allow exception handling code to catch a more specific exception and differentiate between unexpected errors and expected errors.

This is largely non-breaking because OrchestrationAlreadyExistsException already derives from InvalidOperationException.

Note that the IOrchestrationServiceClient interface already documents that the CreateTaskOrchestrationAsync methods should be throwing OrchestrationAlreadyExistsException, so this change fixes the AzureStorageOrchestrationService's implementation to follow the existing spec.

@cgillum cgillum requested review from jviau and davidmrdavid April 5, 2024 01:53
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for CI

@cgillum
Copy link
Member Author

cgillum commented Apr 5, 2024

Looks like the failing CI is new and not part of our normal CIs. I think we can safely ignore its results.

@davidmrdavid
Copy link
Collaborator

@cgillum: agreed. Surprised to see it running automatically on every PR, but that's fine since it's just tests.

@cgillum cgillum merged commit e0731b6 into main Apr 5, 2024
2 of 3 checks passed
@cgillum cgillum deleted the cgillum/already-exists-exception branch April 5, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants