Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

az cli client cleanup #434

Merged
merged 12 commits into from
Dec 3, 2024
Merged

az cli client cleanup #434

merged 12 commits into from
Dec 3, 2024

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Nov 22, 2024 •
edited
Loading

  • move az cli methods to within the azClient
  • consume CommandRunner for az cli
  • update Ensure/Validation for AzCLI to methods that return errors so we can consume and test them directly via fakeCommandRunners
  • revert contributor role to allow acr build and push for github action

@davidgamero davidgamero marked this pull request as ready for review November 22, 2024 03:34
@Tatsinnit Tatsinnit added the enhancement New feature or request label Nov 25, 2024
Tatsinnit
Tatsinnit approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you so much for this and for the ping, added small notes, I think there is more history to this PR, so added few more folks, but looks good to me and surely these changes will get tested just to be sane before release.

pkg/prompts/prompts.go Outdated Show resolved Hide resolved
pkg/providers/azcli.go Outdated Show resolved Hide resolved
pkg/providers/azure.go Show resolved Hide resolved
@davidgamero davidgamero merged commit 0159693 into main Dec 3, 2024
149 checks passed
@davidgamero davidgamero deleted the davidgamero/azcli-client-cleanup branch December 3, 2024 21:51
@bfoley13 bfoley13 mentioned this pull request Dec 4, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Dec 5, 2024
Merged
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 13, 2024
@davidgamero @audrastump
az cli client cleanup (Azure#434)
9e05073
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 16, 2024
@davidgamero @audrastump
az cli client cleanup (Azure#434)
c358f7a
audrastump pushed a commit to audrastump/draft that referenced this pull request Dec 19, 2024
@davidgamero @audrastump
az cli client cleanup (Azure#434)
706c258
audrastump pushed a commit to audrastump/draft that referenced this pull request Jan 2, 2025
@davidgamero @audrastump
az cli client cleanup (Azure#434)
fbebe32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@bfoley13 bfoley13 bfoley13 approved these changes

@Vidya2606 Vidya2606 Awaiting requested review from Vidya2606

@aamgayle aamgayle Awaiting requested review from aamgayle

@erinborders erinborders Awaiting requested review from erinborders

@bosesuneha bosesuneha Awaiting requested review from bosesuneha

Assignees

@davidgamero davidgamero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgamero @bfoley13 @Tatsinnit