Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DraftConfig to contain more metadata #381

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

bfoley13
Copy link
Member

@bfoley13 bfoley13 commented Sep 10, 2024

Description

This PR starts the initial changes for updated template handling and adds:

  1. Updated DraftConfig fields
  2. Adding top level Templates FS containing all templates
  3. Running initial validation on unique template names and valid template type/kind

This does not add versions into the draft.yaml files yet. We will add versions once we have updated the templates to what we want in our initial version.

Also added this repo github actions into dependabot as well as update the CodeQL actions to v3

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Local Unit Testing
  • Pipeline Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bfoley13 bfoley13 enabled auto-merge (squash) September 11, 2024 13:46
@bfoley13 bfoley13 merged commit 118621f into main Sep 12, 2024
152 checks passed
@bfoley13 bfoley13 deleted the brfole/draftconfig-updates branch September 12, 2024 17:14
@bfoley13 bfoley13 mentioned this pull request Oct 22, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants