Fix #175: Mount AZURE_CONFIG_DIR folder instead of ~/.azure
#176
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
reviewed
Jan 15, 2025
| @@ -52,6 +52,9 @@ export async function main() { | |||
| inlineScript = ` set -e >&2; echo '${START_SCRIPT_EXECUTION_MARKER}' >&2; ${inlineScript}`; | |||
| scriptFileName = await createScriptFile(inlineScript); | |||
|
|
|||
| const azureConfigDir = process.env.AZURE_CONFIG_DIR || path.join(process.env.HOME, '.azure'); | |||
| process.env.AZURE_CONFIG_DIR = '/root/.azure'; | |||
There was a problem hiding this comment.
This changes the AZURE_CONFIG_DIR env var of the host.
If any Azure CLI command is run after docker run is executed, it will see AZURE_CONFIG_DIR as /root/.azure which doesn't exist on the host.
I would recommend exactly setting AZURE_CONFIG_DIR env var of the docker process via -e, --env, instead of inheriting from process.env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a breaking change made in the latest GitHub runner image,
AZURE_CONFIG_DIRwas set to/opt/az-config. Since Azure/cli used to mount the~/.azurefolder as the user's Azure configuration directory, this will cause Azure/cli to not work with Azure/login. In this pr, we will mountAZURE_CONFIG_DIRfolder instead of~/.azure, and reset theAZURE_CONFIG_DIRto/root/.azurewithin this action.Test: https://github.com/Azure/azclitools-actions-test/actions/runs/12782376451/job/35631745972
Close #175