Suppress 'Report an issue' on .NET acquisition failure #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94099ac to
26379af
Compare
26379af to
39acbe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New experience (tested by setting dotnet version to "100.0"):
This removes the "Report an issue" button and instead points users to use the error dialog reported by the .NET acquisition tool (which is able to capture context & logs, and triggers a report to the dotnet runtime repo rather than this one). Our current "Report an Issue" button has no available context about the failure, which leads to unactionable issue reports like:
Closes #2428