feat: avm/res/desktop-virtualization/application-group
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moisesjgomez - it appears your latest run is failing |
avm/res/desktop-virtualization/application-group/tests/e2e/defaults/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/desktop-virtualization/application-group/modules/application.bicep
Outdated
Show resolved
Hide resolved
avm/res/desktop-virtualization/application-group/modules/application.bicep
Outdated
Show resolved
Hide resolved
avm/res/desktop-virtualization/application-group/tests/e2e/max/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/desktop-virtualization/application-group/tests/e2e/max/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/desktop-virtualization/application-group/tests/e2e/max/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/desktop-virtualization/application-group/tests/e2e/max/main.test.bicep
Outdated
Show resolved
Hide resolved
…cation.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…/dependencies.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…/dependencies.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…/dependencies.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…/main.test.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Hey @moisesjgomez - the pipeline badge seems gone as are your workflow runs. I guess you reset your fork? Anyways - code-wise all looks good, just would like to see a pipeline badge to ensure the latest tests pass and we're good to go :)
Assuming this is due to the issues with GH Login.... @moisesjgomez please update the badge when you are able to do a pipeline run next! |
AlexanderSehr
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes avm/res/desktop-virtualization/application-group #146
Adding a new module
brm validatelocally to verify the module files.