Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Module avm/res/compute/proximity-placement-group #762

Merged
merged 11 commits into from
Jan 4, 2024
Merged

feat: New Module avm/res/compute/proximity-placement-group #762

merged 11 commits into from
Jan 4, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Jan 3, 2024

Description

New Module avm/res/compute/proximity-placement-group, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.compute.proximity-placement-group

@krbar krbar self-assigned this Jan 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 3, 2024
@krbar krbar marked this pull request as ready for review January 3, 2024 21:47
@krbar krbar requested review from a team as code owners January 3, 2024 21:47
@krbar krbar mentioned this pull request Jan 3, 2024
Closed
2 tasks
ChrisSidebotham
ChrisSidebotham approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good @krbar

@ChrisSidebotham ChrisSidebotham merged commit f0b7ac3 into Azure:main Jan 4, 2024
9 checks passed
@matebarabas matebarabas mentioned this pull request Jan 4, 2024
Closed
@krbar krbar mentioned this pull request Jan 4, 2024
Merged
4 tasks
@krbar krbar deleted the users/krbar/ppgModule branch January 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSidebotham ChrisSidebotham ChrisSidebotham approved these changes

Assignees

@krbar krbar

Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krbar @ChrisSidebotham