Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Module avm/res/sql/server #637

Merged
merged 30 commits into from
Nov 21, 2023
Merged

feat: New Module avm/res/sql/server #637

merged 30 commits into from
Nov 21, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Nov 16, 2023 •
edited
Loading

Description

New Module avm/res/sql/server, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.sql.server

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 16, 2023
@krbar krbar marked this pull request as ready for review November 16, 2023 15:26
@krbar krbar requested review from a team as code owners November 16, 2023 15:26
krbar and others added 7 commits November 16, 2023 21:45
@krbar @AlexanderSehr
Update avm/res/sql/server/database/backup-short-term-retention-policy…
0e0fdb2 
…/main.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@krbar @AlexanderSehr
Update avm/res/sql/server/database/backup-short-term-retention-policy…
4d96b6c 
…/main.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@krbar @AlexanderSehr
Update avm/res/sql/server/database/backup-long-term-retention-policy/…
df3a6c6 
…main.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@krbar @AlexanderSehr
Update avm/res/sql/server/database/main.bicep
fd86dff 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@krbar @AlexanderSehr
Update avm/res/sql/server/database/backup-long-term-retention-policy/…
0aa2ba2 
…main.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@krbar @AlexanderSehr
Update avm/res/sql/server/tests/e2e/defaults/main.test.bicep
602c32d 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@krbar @AlexanderSehr
Update avm/res/sql/server/vulnerability-assessment/main.bicep
9e45e5e 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@matebarabas matebarabas mentioned this pull request Nov 20, 2023
Closed
2 tasks
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Nov 20, 2023
@krbar krbar requested a review from a team as a code owner November 20, 2023 23:55
@AlexanderSehr AlexanderSehr merged commit e953305 into Azure:main Nov 21, 2023
9 checks passed
@krbar krbar deleted the users/krbar/sqlModule branch November 21, 2023 15:27
@krbar krbar mentioned this pull request Nov 21, 2023
Merged
4 tasks
@matebarabas matebarabas mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@krbar krbar

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krbar @AlexanderSehr @matebarabas