-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/ptn/data/private-analytical-workspace
V0.1
#3307
feat: avm/ptn/data/private-analytical-workspace
V0.1
#3307
Conversation
…nko/bicep-registry-modules into private-analytical-workspace
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Small addition: It seems to be related to: PowerShell/PowerShell#23197 (comment) |
OK, all changes completed on my side. Ready for merge. Tests and deployments are passing. @AlexanderSehr pipeline succeeds if I do changes you proposed in the file \avm\utilities\pipelines\sharedScripts\Set-EnvironmentOnAgent.ps1. Those changes are not included in this PR. I removed them after try. I expect this will be changed in the main in original repo. |
Hey @jbinko, |
Thanks @AlexanderSehr - got it. I fixed the remove of default test location and virtual network name propagation into dependencies files in tests. Should be ready for merge now. |
Thanks @AlexanderSehr, I created new PR #3626 which addresses the post deployment tests issue. |
…andom locations (#3626) ## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #3307 --> Fixes #3307 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | [![avm.ptn.data.private-analytical-workspace](https://github.com/jbinko/bicep-registry-modules/actions/workflows/avm.ptn.data.private-analytical-workspace.yml/badge.svg?branch=private-analytical-workspace-tests-neu&event=workflow_dispatch)](https://github.com/jbinko/bicep-registry-modules/actions/workflows/avm.ptn.data.private-analytical-workspace.yml) ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
Description
This is the initial implementation of the proposed pattern module detailed in proposal. Azure/Azure-Verified-Modules#949 It includes documentation, unit tests, and PowerShell post-unit tests.
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.