Reset link credit on last transfer legally received #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a problematic code, since if the current credit is already zero, the sender will not have sent another transfer.
else if (is_transfer_type_by_descriptor(descriptor))
{
if (link_instance->on_transfer_received != NULL)
{
TRANSFER_HANDLE transfer_handle;
if (amqpvalue_get_transfer(performative, &transfer_handle) != 0)
{
LogError("Cannot get transfer performative");
}
else
{
AMQP_VALUE delivery_state;
bool more;
bool is_error;
if (link_instance->current_link_credit == 0)
That can be verified in the AMQP 1.0 spec in "2.6.7 Flow Control":
"If the link-credit is less than or equal to zero, i.e. the delivery-count is the same as or greater than the delivery-limit, it is illegal to send more messages."
Here the code is already automatically replenishing the link credit if it gets "too low".
In such case, it should check if the link credit gets down to 1 or less (for the last message that the sender can legally send) and then replenish, also sending a new flow to the sender.
Btw, this is a new bug caused by this change:
https://github.com/Azure/azure-uamqp-c/pull/383/files
The current issue that best matches this bug is #461
ericwolz
approved these changes
Jun 17, 2024
|
UT needed? |
Added. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a problematic code, since if the current credit is already zero, the sender will not have sent another transfer.
That can be verified in the AMQP 1.0 spec in "2.6.7 Flow Control": "If the link-credit is less than or equal to zero, i.e. the delivery-count is the same as or greater than the delivery-limit, it is illegal to send more messages."
Here the code is already automatically replenishing the link credit if it gets "too low". In such case, it should check if the link credit gets down to 1 or less (for the last message that the sender can legally send) and then replenish, also sending a new flow to the sender.
Btw, this is a new bug caused by this change:
https://github.com/Azure/azure-uamqp-c/pull/383/files
The current issue that best matches this bug is #461