Go1.15 #205
Merged
Go1.15 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update go to latest version Update adal dependency
|
Hey @elsesiy , Thanks for reaching out and for your contribution!! |
mohsha-msft
pushed a commit
that referenced
this pull request
Aug 31, 2020
Update go to latest version Update adal dependency
nakulkar-msft
added a commit
that referenced
this pull request
Oct 27, 2020
* Add illumos build tag additionally to solaris * #7508079 [Go][Blob][2019-12-12] Blob Versioning (#190) * Generated code for 12-12-2019 spec * Fix test * Changes * Basic Testing and modification in WithVersionId function. * Added Tags and Versions in BlobListingDetails. * Added Tests * Added TestCases * Commented out tests which require versioning disabled. * Added Tests * Testcases 1-on-1 with python SDK * Moved all tests to same file for ease of accessibility Co-authored-by: zezha-msft <zezha@microsoft.com> * update to go1.14 * Minor Jumbo Blob Fix and Blob Versioning fix (#198) * Minor Jumbo Blob fix + versioning fix * Test Case Fix * Renamed struct back to original * Changed block blob limit (#199) * Minor versioning fix (#200) * [Go][Blob][2019-02-02] Set tier support on copy/put blob API (#203) * Added tier parameter in upload block blob function signature + Fixed usage + Wrote a test case for validation. * Added tier parameter in a. CopyFromURL, CommitBlockList of Block Blob b. Create (Page Blob) Fixed all occurrence * Minor Change * Added test * Rev go to 1.15, adal to 0.9.2 (#205) Update go to latest version Update adal dependency * #7508079 [Go][Blob][2019-12-12] Blob Versioning (#190) * Generated code for 12-12-2019 spec * Fix test * Changes * Basic Testing and modification in WithVersionId function. * Added Tags and Versions in BlobListingDetails. * Added Tests * Added TestCases * Commented out tests which require versioning disabled. * Added Tests * Testcases 1-on-1 with python SDK * Moved all tests to same file for ease of accessibility Co-authored-by: zezha-msft <zezha@microsoft.com> * Minor Jumbo Blob Fix and Blob Versioning fix (#198) * Minor Jumbo Blob fix + versioning fix * Test Case Fix * Renamed struct back to original * Changed block blob limit (#199) * update to go1.14 * Minor versioning fix (#200) * [Go][Blob][2019-02-02] Set tier support on copy/put blob API (#203) * Added tier parameter in upload block blob function signature + Fixed usage + Wrote a test case for validation. * Added tier parameter in a. CopyFromURL, CommitBlockList of Block Blob b. Create (Page Blob) Fixed all occurrence * Minor Change * Added test * Rev go to 1.15, adal to 0.9.2 (#205) Update go to latest version Update adal dependency * Fixing BlockBlobMaxUploadBlobBytes value (#207) Reverting BlockBlobMaxUploadBlobBytes to 256MB * Consider 502 as a temporary error (#204) * [highlevel] Stop using memory-mapped files While investigating this SDK for uploading and downloading large blobs (e.g. 25GB or more) it became apparent that the memory-mapped approach has some severe limitations: 1. Limits the file size on 32-bit systems (theoretically 4GB, but much less in practice). 2. Has no backpressure when writing to slower storage mediums. 3. Appears to finish faster, but the OS spends several minutes flushing the modified RAM to disk afterwards (depends on the speed of the disk). On a VM with 16GB of RAM and a slow disk (spinning in this case) the algorithm quickly overwhelms the available memory and causes severe performance degradation. It ended up simultaneously trying to flush to the slow data disk and page out to the slightly faster OS disk. The solution is to stop using memory-mapped files (at least the way the SDK currently uses then) and switch to the `io.ReaderAt` and `io.WriterAt` interfaces. They explicitly allow for parallel access to non-overlapping regions which make them a good candidate for this purpose. Benchmarking large downloads (25GB file) between azcopy 10.4.3 and these updates using a test app, the difference between them is within 10 seconds. When compared against the original code on a beefy machine with plenty of RAM the measured execution time is faster, but there is a little bit of delay while the last of the data flushes from RAM to disk. * PR feedback Co-authored-by: Till Wegmueller <toasterson@gmail.com> Co-authored-by: Ze Qian Zhang <zezha@microsoft.com> Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Co-authored-by: Jonas-Taha El Sesiy <github@elsesiy.com> Co-authored-by: mohsha-msft <mohsha@microsoft.com> Co-authored-by: Kyle Farnung <kfarnung@outlook.com>
nakulkar-msft
added a commit
that referenced
this pull request
Dec 24, 2020
* Add illumos build tag additionally to solaris * #7508079 [Go][Blob][2019-12-12] Blob Versioning (#190) * Generated code for 12-12-2019 spec * Fix test * Changes * Basic Testing and modification in WithVersionId function. * Added Tags and Versions in BlobListingDetails. * Added Tests * Added TestCases * Commented out tests which require versioning disabled. * Added Tests * Testcases 1-on-1 with python SDK * Moved all tests to same file for ease of accessibility Co-authored-by: zezha-msft <zezha@microsoft.com> * update to go1.14 * Minor Jumbo Blob Fix and Blob Versioning fix (#198) * Minor Jumbo Blob fix + versioning fix * Test Case Fix * Renamed struct back to original * Changed block blob limit (#199) * Minor versioning fix (#200) * [Go][Blob][2019-02-02] Set tier support on copy/put blob API (#203) * Added tier parameter in upload block blob function signature + Fixed usage + Wrote a test case for validation. * Added tier parameter in a. CopyFromURL, CommitBlockList of Block Blob b. Create (Page Blob) Fixed all occurrence * Minor Change * Added test * Rev go to 1.15, adal to 0.9.2 (#205) Update go to latest version Update adal dependency * #7508079 [Go][Blob][2019-12-12] Blob Versioning (#190) * Generated code for 12-12-2019 spec * Fix test * Changes * Basic Testing and modification in WithVersionId function. * Added Tags and Versions in BlobListingDetails. * Added Tests * Added TestCases * Commented out tests which require versioning disabled. * Added Tests * Testcases 1-on-1 with python SDK * Moved all tests to same file for ease of accessibility Co-authored-by: zezha-msft <zezha@microsoft.com> * Minor Jumbo Blob Fix and Blob Versioning fix (#198) * Minor Jumbo Blob fix + versioning fix * Test Case Fix * Renamed struct back to original * Changed block blob limit (#199) * update to go1.14 * Minor versioning fix (#200) * [Go][Blob][2019-02-02] Set tier support on copy/put blob API (#203) * Added tier parameter in upload block blob function signature + Fixed usage + Wrote a test case for validation. * Added tier parameter in a. CopyFromURL, CommitBlockList of Block Blob b. Create (Page Blob) Fixed all occurrence * Minor Change * Added test * Rev go to 1.15, adal to 0.9.2 (#205) Update go to latest version Update adal dependency * Fixing BlockBlobMaxUploadBlobBytes value (#207) Reverting BlockBlobMaxUploadBlobBytes to 256MB * Consider 502 as a temporary error (#204) * [highlevel] Stop using memory-mapped files While investigating this SDK for uploading and downloading large blobs (e.g. 25GB or more) it became apparent that the memory-mapped approach has some severe limitations: 1. Limits the file size on 32-bit systems (theoretically 4GB, but much less in practice). 2. Has no backpressure when writing to slower storage mediums. 3. Appears to finish faster, but the OS spends several minutes flushing the modified RAM to disk afterwards (depends on the speed of the disk). On a VM with 16GB of RAM and a slow disk (spinning in this case) the algorithm quickly overwhelms the available memory and causes severe performance degradation. It ended up simultaneously trying to flush to the slow data disk and page out to the slightly faster OS disk. The solution is to stop using memory-mapped files (at least the way the SDK currently uses then) and switch to the `io.ReaderAt` and `io.WriterAt` interfaces. They explicitly allow for parallel access to non-overlapping regions which make them a good candidate for this purpose. Benchmarking large downloads (25GB file) between azcopy 10.4.3 and these updates using a test app, the difference between them is within 10 seconds. When compared against the original code on a beefy machine with plenty of RAM the measured execution time is faster, but there is a little bit of delay while the last of the data flushes from RAM to disk. * PR feedback Co-authored-by: Till Wegmueller <toasterson@gmail.com> Co-authored-by: Ze Qian Zhang <zezha@microsoft.com> Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Co-authored-by: Jonas-Taha El Sesiy <github@elsesiy.com> Co-authored-by: mohsha-msft <mohsha@microsoft.com> Co-authored-by: Kyle Farnung <kfarnung@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go to latest version
Update adal dependency