Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamic expression Secret and ConfigMap outputs #4398

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Add support for dynamic expression Secret and ConfigMap outputs #4398

merged 3 commits into from
Nov 7, 2024

Conversation

matthchr
Copy link
Member

  • Add generator support for dynamic configmap and secret export.
  • Add webhook validation for new operatorSpec fields.
  • Add generic controller integration to output expressions to
    ConfigMap/Secret.
  • Add CEL tests
  • Fix a few issues with CEL expression parsing.

Resolves #2555

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@matthchr matthchr added this to the v2.11.0 milestone Oct 31, 2024
@matthchr matthchr self-assigned this Oct 31, 2024
@matthchr
Copy link
Member Author

Recommend reviewers review by commit and they can bypass (or review last) the "generate APIs" commit.

@matthchr matthchr force-pushed the feature/dynamic-exports branch from 89a6faa to 10067e4 Compare October 31, 2024 22:43
theunrepentantgeek
theunrepentantgeek approved these changes Nov 6, 2024
View reviewed changes
docs/hugo/content/guide/expressions.md Outdated Show resolved Hide resolved
docs/hugo/content/guide/expressions.md Outdated Show resolved Hide resolved
docs/hugo/content/guide/expressions.md Show resolved Hide resolved
@matthchr matthchr force-pushed the feature/dynamic-exports branch from 10067e4 to 84443e8 Compare November 6, 2024 23:59
@matthchr
Copy link
Member Author

matthchr commented Nov 7, 2024

/ok-to-test sha=84443e8

@matthchr
Add support for dynamic expression Secret and ConfigMap outputs
5a219c3 
 * Add generator support for dynamic configmap and secret export.
 * Add webhook validation for new operatorSpec fields.
 * Add generic controller integration to output expressions to
   ConfigMap/Secret.
 * Add CEL tests
 * Fix a few issues with CEL expression parsing.
@matthchr
Regenerate api
11a8f82
@matthchr
Add CEL Expressions documentation
676b167
@matthchr matthchr force-pushed the feature/dynamic-exports branch from 84443e8 to 676b167 Compare November 7, 2024 01:19
@matthchr
Copy link
Member Author

matthchr commented Nov 7, 2024

/ok-to-test sha=676b167

@matthchr matthchr added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@matthchr matthchr added this pull request to the merge queue Nov 7, 2024
Merged via the queue into Azure:main with commit 97d0ccf Nov 7, 2024
8 checks passed
@matthchr matthchr deleted the feature/dynamic-exports branch November 7, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theunrepentantgeek theunrepentantgeek theunrepentantgeek approved these changes

@davefellows davefellows Awaiting requested review from davefellows davefellows is a code owner

@babbageclunk babbageclunk Awaiting requested review from babbageclunk babbageclunk is a code owner

@super-harsh super-harsh Awaiting requested review from super-harsh super-harsh is a code owner

Assignees

@matthchr matthchr

Labels
None yet
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Feature: Support dynamic secret/configmap exports
2 participants
@matthchr @theunrepentantgeek