Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken documentation link #2780

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Our documentation builds have been broken since a refactoring of the MySQL Swagger specs.

Special notes for your reviewer:

I think I have the right target link; @matthchr please check.

@@ -75,8 +75,8 @@ Below is a table containing a sampling of resources with secrets that ASO alread

| CRD | User provided secrets | Azure generated secrets | AAD/Managed Identity Support | Notes |
| -------------------------- | --------------------- | ----------------------- | ---------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| VirtualMachineScaleSet | ✔️ | ❌ | ❌ | `Username` and `Password`. Can be modified by subsequent PUT. |
| VirtualMachine | ✔️ | ❌ | ❌ | `Username` and `Password`. Can be modified by subsequent PUT. |
| VirtualMachineScaleSet | ✔️ | ❌ | ❌ | `Username` and `Password`. Can be modified by subsequent PUT. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the change here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is whitespace fixes by a VS Code plugin formatting the table.

@theunrepentantgeek theunrepentantgeek merged commit cc6fb2b into main Mar 14, 2023
@theunrepentantgeek theunrepentantgeek deleted the fix/broken-mysql-link branch March 14, 2023 06:49
emilychu9318 pushed a commit to emilychu9318/azure-service-operator that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants