-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken documentation link #2780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
reviewed
Mar 14, 2023
@@ -75,8 +75,8 @@ Below is a table containing a sampling of resources with secrets that ASO alread | |||
|
|||
| CRD | User provided secrets | Azure generated secrets | AAD/Managed Identity Support | Notes | | |||
| -------------------------- | --------------------- | ----------------------- | ---------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| VirtualMachineScaleSet | ✔️ | ❌ | ❌ | `Username` and `Password`. Can be modified by subsequent PUT. | | |||
| VirtualMachine | ✔️ | ❌ | ❌ | `Username` and `Password`. Can be modified by subsequent PUT. | | |||
| VirtualMachineScaleSet | ✔️ | ❌ | ❌ | `Username` and `Password`. Can be modified by subsequent PUT. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is whitespace fixes by a VS Code plugin formatting the table.
super-harsh
approved these changes
Mar 14, 2023
emilychu9318
pushed a commit
to emilychu9318/azure-service-operator
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our documentation builds have been broken since a refactoring of the MySQL Swagger specs.
Special notes for your reviewer:
I think I have the right target link; @matthchr please check.