Fix NamespaceClient.GetNamespaceInfoAsync() #638
Conversation
|
This will need to be a minor release as we're adding to the public API of an existing type |
|
@nemakam should we deprecate |
| @@ -730,6 +730,7 @@ namespace Microsoft.Azure.ServiceBus.Management | |||
| public enum NamespaceType | |||
| { | |||
| ServiceBus = 0, | |||
| Messaging = 1, | |||
There was a problem hiding this comment.
This is actually not true. Problem is that ServiceBus is called Messaging in service side. Didnt realize when I renamed the enum. The correct thing is to rename ServiceBus to Messaging. But that is going to break things. So the alternative that I can think of is to manually handle the deserialization and if it is Messaging, then convert it to ServiceBus. :(
|
I can live with that, but we'll need to change that in v4.
Sean Feldman
…On Sat., Jan. 26, 2019, 00:00 Neeraj Makam ***@***.*** wrote:
***@***.**** requested changes on this pull request.
------------------------------
In
test/Microsoft.Azure.ServiceBus.UnitTests/API/ApiApprovals.ApproveAzureServiceBus.approved.txt
<#638 (comment)>
:
> @@ -730,6 +730,7 @@ namespace Microsoft.Azure.ServiceBus.Management
public enum NamespaceType
{
ServiceBus = 0,
+ Messaging = 1,
This is actually not true. Problem is that ServiceBus is called Messaging
in service side. Didnt realize when I renamed the enum. The correct thing
is to rename ServiceBus to Messaging. But that is going to break things.
So the alternative that I can think of is to manually handle the
deserialization and if it is Messaging, then convert it to ServiceBus. :(
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#638 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABP7tk_sjm3RvVJMmGrmodcrrHfX26Dkks5vG4x9gaJpZM4aQGsU>
.
|
This reverts commit dd9b298.
|
@nemakam updated |
|
@nemakam could you please raise an issue for 4.0.0 milestone to address f10cae9#diff-4f0427b57425e52bf6ea1d62facac6b9R69? Thanks. |
|
@nemakam please review |
|
@nemakam who could review this? |
|
I guess we could just leave it as-is. In reply to: 457061141 [](ancestors = 457061141) |
Fixes #637