This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Keep delivery count as-is when peeking a message #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31c821f to
f48f2fc
Compare
|
@nemakam ready to be reviewed |
|
Could you add a new assert line for delivery count in one of the existing test for peek and peeklock? |
|
Added a test against real queue. |
1360ca2 to
86cd9fc
Compare
|
@nemakam two tests running against real queues - one for Peek and one for Receive operations. |
|
@nemakam in place |
|
Anything else that is missing on this PR @nemakam ? |
|
PR is completed and ready to be reviewed/merged |
|
Risking to piss off people here, but any chance to have this included in 3.2.0 release? |
nemakam
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589