Update get-codeowners PowerShell file #981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
601c13e to
66dab2b
Compare
9d5df89 to
fd73e1d
Compare
weshaggard
reviewed
Sep 22, 2020
weshaggard
reviewed
Sep 22, 2020
| { | ||
| $previousLine = $previousLine.substring($previousLine.IndexOf(':') + 1) | ||
| $splitPrevLine = $previousLine -split "%" | ||
| $labels = ($splitPrevLine[1..$($splitPrevLine.Length)] | % { return $_.Trim() }) -join "," |
There was a problem hiding this comment.
Lets make remove the join here and keep it an array.
weshaggard
reviewed
Sep 22, 2020
weshaggard
approved these changes
Sep 22, 2020
e9c591e to
c34b268
Compare
ghost
referenced
this pull request
in Azure/azure-sdk-for-net
Sep 24, 2020
Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/981<br> See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)
weshaggard
reviewed
Sep 24, 2020
| if ($presentOwningUsers) { | ||
| $users += $presentOwningUsers | ||
| } | ||
| Write-Host "##vso[task.setvariable variable=$VsoOwningUsers;]($users -join ',')" |
There was a problem hiding this comment.
Suggested change
| Write-Host "##vso[task.setvariable variable=$VsoOwningUsers;]($users -join ',')" | |
| Write-Host "##vso[task.setvariable variable=$VsoOwningUsers;]$($users -join ',')" |
weshaggard
reviewed
Sep 24, 2020
| if ($presentOwningTeams) { | ||
| $teams += $presentOwningUsers | ||
| } | ||
| Write-Host "##vso[task.setvariable variable=$VsoOwningTeams;]($teams -join ',')" |
There was a problem hiding this comment.
Suggested change
| Write-Host "##vso[task.setvariable variable=$VsoOwningTeams;]($teams -join ',')" | |
| Write-Host "##vso[task.setvariable variable=$VsoOwningTeams;]$($teams -join ',')" |
weshaggard
reviewed
Sep 24, 2020
| } | ||
| Write-Host "##vso[task.setvariable variable=$VsoVariable;]$results" | ||
| Write-Host "##vso[task.setvariable variable=$VsoOwningLabels;]($labels -join ',')" |
There was a problem hiding this comment.
Suggested change
| Write-Host "##vso[task.setvariable variable=$VsoOwningLabels;]($labels -join ',')" | |
| Write-Host "##vso[task.setvariable variable=$VsoOwningLabels;]$($labels -join ',')" |
c34b268 to
a587e76
Compare
weshaggard
reviewed
Sep 24, 2020
| ) | ||
|
|
||
| . (Join-Path ${PSScriptRoot} logging.ps1) |
There was a problem hiding this comment.
Any reason not to import common.ps1?
weshaggard
reviewed
Sep 24, 2020
| | ? { $_.StartsWith("@") } ` | ||
| | % { return $_.substring(1) }) -join "," | ||
|
|
||
| $aliases = ($splitLine[1..$($splitLine.Length)] | ? { $_.StartsWith("@") } | % { return $_.substring(1) }) -join "," |
There was a problem hiding this comment.
Given that you split on "," below we should just avoid the join here and just keep an array.
|
Any updates to this PR? Is it still being worked on? If this is blocked on something, can you link to the PRs or issues in the description that we are waiting on. |
Done |
|
Closing this, till I get to come back to it. |
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
…nce some embedded platforms don't have it. (Azure#981) * Use custom, portable implementation of IEEE 754 compliant isfinite since some platforms dont have it. * Add some comments to test cases. * Inline the implementation of _az_is_finite. * Reword the comment slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend CodeOwners.ps1 to recognize Labels and team aliases in code owners file.
Addresses Azure/azure-sdk-for-net#14760 and #954
Blocked on #1052