Fix Integration Issue w/ Create-PRJobMatrix
#9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Oct 31, 2024
|
The following pipelines have been queued for testing: |
benbp
approved these changes
Oct 31, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving: 2c03fac#r1823660311
And due to the fact that because we were nulling out the matrix configs, we weren't iterating over it and calling GenerateMatrixForConfig.
If not using this PR, we get: https://dev.azure.com/azure-sdk/public/_build/results?buildId=4284719&view=logs&j=76992fd1-2312-5fae-7c45-7baba86b87ae&t=6c294a88-3151-521e-fcd8-a6c587ba9418