-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Changelog Logic #823
Restructure Changelog Logic #823
Conversation
e9293e0
to
34a1253
Compare
3e87c44
to
0457e4b
Compare
5437296
to
a357775
Compare
a357775
to
f0b4d92
Compare
@@ -3,17 +3,11 @@ param ( | |||
[String]$ChangeLogLocation, | |||
[String]$VersionString, | |||
[string]$PackageName, | |||
[string]$ServiceName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes will break any consumers so somehow we need to figure out a way of not breaking them.
One potential way is to make changes additive and then go back in after you moved everyone to the new approach and remove the unused parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course this is only an issue if there is anyone directly calling this script. If they are all using the yml template you can do what I suggested in my comment in the template to handle the break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to go with making the changes additive. So I added the new files and will switch then over in the languages repo so I can make sure it all works and there is no tome where things are broken. The only down side is that I have appended -2
to the files names which is a little weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally wouldn't create a new template but instead just make the changes to the existing template additive like I suggested. If you add the second template you will have the same problem when you want to clean that script up.
@@ -2,7 +2,7 @@ parameters: | |||
- name: PackageName | |||
type: string | |||
default: 'not-specified' | |||
- name: ServiceName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps as a transition you have both ServiceName and ServiceDirectory and you do something like coalesce(parameters.ServiceDirectory, parameters.ServiceName)
, and then once you have converted all the usages you can remove the ServiceName parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets correctly order this tools change and the language changes to ensure we don't have any breaks. Even if that means duplicate parameters temporarily.
f0b4d92
to
fee2562
Compare
f8589d8
to
66c8172
Compare
66c8172
to
39b77af
Compare
/check-enforcer override |
Restructure changelog logic to remove reliance on modules and make use of
eng\common\scripts\common.ps1