Case Insensitive Moniker Parsing #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeownersUtils was parsing Monikers case sensitive. The problem here is that any line that starts with # and doesn't match a moniker is treated as just a comment and ignored. CODEOWNERS files have blocks that are Moniker/Comment/MonikerOrSourceLine.
The main reason to make the moniker parsing case insensitive is that it would be more painful to try and plumb a casing error through the utils for just the linter. Parsing in any other context (github-event-processor or pipeline-owners-extractor) doesn't error, it throws out CODEOWNERS entries that are in error or, if the case of a mis cased moniker, would omit that piece of data from the entry. For example, if instead of PRLabel, the moniker in the file was prLabel it would treat that as a comment and ignore it but would still have the source path/owner in the CODEOWNERS entry with no PRLabel associated with it.
Moved the update to METADATA.md to this PR instead of the event processor PR.
The change adds a moniker to two example blocks that should have been there.