Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git commit details to stress environment #7543

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add git commit details to stress environment #7543

merged 1 commit into from
Jan 18, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Jan 17, 2024 •
edited
Loading

Fixes #7521 #4644. See README.md diff in PR for details.

FYI @lmolkova @richardpark-msft

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jan 17, 2024
@benbp benbp self-assigned this Jan 17, 2024
@benbp benbp added the Stress This issue is related to stress testing, part of our reliability pillar. label Jan 17, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jan 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise seems good.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/stress-git-commit branch from 44f78c5 to 343d917 Compare January 18, 2024 19:07
@benbp benbp force-pushed the benbp/stress-git-commit branch from 343d917 to 1f76f94 Compare January 18, 2024 19:10
@benbp
Copy link
Member Author

benbp commented Jan 18, 2024

One suggestion but otherwise seems good.

@weshaggard looks like --git-dir only works if pointing at the .git directory, but -C has the intended effect.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Jan 18, 2024
View reviewed changes
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
"--set", "stress-test-addons.env=$environment"
)

$gitCommit = git -C $pkg.Directory rev-parse HEAD 2>&1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want -C here do you? When I tried that locally I don't think it worked. I thought that was referring to the configuration location.

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 18, 2024
@azure-sdk @benbp
Sync eng/common directory with azure-sdk-tools for PR 7543 (#28281)
db0a448 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7543 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@weshaggard
Copy link
Member

weshaggard commented Jan 18, 2024 •
edited
Loading

One suggestion but otherwise seems good.

@weshaggard looks like --git-dir only works if pointing at the .git directory, but -C has the intended effect.

That is interesting as that I had the opposite when I tested locally. I could point to the folder that contained the .git directory and I thought -C was for the configuration file.

edit: After looking at https://git-scm.com/docs/git#Documentation/git.txt--Cltpathgt what you say seems correct I guess I will need to do some more testing to understand what I saw.

@benbp benbp merged commit 460152d into Azure:main Jan 18, 2024
15 checks passed
@benbp benbp deleted the benbp/stress-git-commit branch January 18, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team. Stress This issue is related to stress testing, part of our reliability pillar.
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add env var with git commit hash to stress test build
3 participants
@benbp @azure-sdk @weshaggard