Stress tests: Fix image tag for multiimage deployments #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Jan 9, 2024
| @@ -302,7 +302,7 @@ function DeployStressPackage( | |||
| } | |||
| } | |||
| $generatedHelmValues.scenarios = @( foreach ($scenario in $generatedHelmValues.scenarios) { | |||
| $dockerPath = if ("image" -notin $scenario) { | |||
| $dockerPath = if ("image" -notin $scenario.keys) { | |||
There was a problem hiding this comment.
$scenarios is a dictionary, and notin checks if item is in the collection, so it never contained image item and did $scenario.imageTag = $imageTag for all scenarios on line 311
|
The following pipelines have been queued for testing: |
richardpark-msft
approved these changes
Jan 9, 2024
benbp
approved these changes
Jan 9, 2024
This was referenced Jan 9, 2024
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jan 9, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7498 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
|
@lmolkova I went ahead and merged this since we have a sync process to the other repos I didn't want you to have to worry about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple docker files are used, one
imageTagvalue was incorrectly applied to all imagesBefore:
resulted in followoing generated values
Now proper
imageTagis generated