Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pipeline to publish Swagger Api Parser package #4203

Merged
merged 13 commits into from
Sep 22, 2022
Merged

Create pipeline to publish Swagger Api Parser package #4203

merged 13 commits into from
Sep 22, 2022

Conversation

praveenkuttappan
Copy link
Member

No description provided.

@praveenkuttappan praveenkuttappan self-assigned this Sep 22, 2022
@praveenkuttappan praveenkuttappan added Central-EngSys This issue is owned by the Engineering System team. APIView labels Sep 22, 2022
@praveenkuttappan
Copy link
Member Author

I have disabled few test cases to get pipeline created.

@praveenkuttappan
Copy link
Member Author

praveenkuttappan commented Sep 22, 2022 •
edited
Loading

Fixes #4204

@praveenkuttappan praveenkuttappan marked this pull request as ready for review September 22, 2022 00:36
@praveenkuttappan praveenkuttappan requested a review from a team as a code owner September 22, 2022 00:36
@ruowan
Copy link
Member

ruowan commented Sep 22, 2022

The folder structure has been changed. You are moving the swaggerApiParserTest to parent folder. Could you explain why we need to do that? And We need to remove orignal swaggerApiParserTest folder.

@praveenkuttappan
Copy link
Member Author

/check-enforcer override

@praveenkuttappan
Copy link
Member Author

/azp run tools - swaggerapiparser

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praveenkuttappan
Copy link
Member Author

/check-enforcer evaluate

@praveenkuttappan
Copy link
Member Author

/check-enforcer override

@praveenkuttappan praveenkuttappan merged commit d7625df into Azure:main Sep 22, 2022
@praveenkuttappan praveenkuttappan deleted the create_swagger_parser_pipeline branch September 22, 2022 17:26
weshaggard
weshaggard reviewed Sep 22, 2022
View reviewed changes
src/dotnet/APIView/APIViewWeb/APIViewWeb.csproj
@@ -13,6 +13,7 @@
<JavaScriptProcessor>..\..\..\..\tools\apiview\parsers\js-api-parser\</JavaScriptProcessor>
<TypeScriptToolsVersion>latest</TypeScriptToolsVersion>
<TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>
<SignAssembly>False</SignAssembly>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not signing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@ruowan ruowan ruowan approved these changes

Assignees

@praveenkuttappan praveenkuttappan

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenkuttappan @ruowan @weshaggard