Skip azcopy download if it already exists #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following pipelines have been queued for testing: |
benbp
approved these changes
Apr 21, 2022
JimSuplizio
approved these changes
Apr 21, 2022
This was referenced Apr 21, 2022
|
🚀 🚀 🚀 |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
weshaggard
reviewed
Apr 26, 2022
| @@ -10,8 +10,10 @@ parameters: | |||
| steps: | |||
| - template: /eng/common/pipelines/templates/steps/set-default-branch.yml | |||
| - pwsh: | | |||
| Invoke-WebRequest -MaximumRetryCount 10 -Uri "https://aka.ms/downloadazcopy-v10-windows" -OutFile "azcopy.zip" | Wait-Process; | |||
| Expand-Archive -Path "azcopy.zip" -DestinationPath "$(Build.BinariesDirectory)/azcopy/" | |||
| if (!(Test-Path '$(Build.BinariesDirectory)/azcopy/azcopy_windows_amd64_*/azcopy.exe')) { | |||
There was a problem hiding this comment.
While this will likely help the immediate issue, we can probably improve this a little further by checking to see if azcopy is already on the path via gcm because I believe it is already on the agents now.
benbp
pushed a commit
to benbp/azure-sdk-tools
that referenced
this pull request
May 6, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.