Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip component governance in generate matrix job #2870

Merged
1 commit merged into from
Mar 15, 2022
+1 −0
Merged

Skip component governance in generate matrix job #2870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ parameters:
jobs:
- job: ${{ parameters.GenerateJobName }}
variables:
skipComponentGovernanceDetection: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about having a globals.yml file in common that could have some common properties. This might be one of them but I'm not sure I would do it just for this one case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed to start popping up for java and adding 3+ minutes to their builds, hence the quick fix. But I agree next time we have to add something similar we can think about adding a globals.yml for eng/common.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a globals.yml. https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/templates/variables/globals.yml

Do we want to serve another purpose

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sima-zhu the challenge is that globals is not in eng/common so it can't be referenced by templates that are in eng/common. I think we would probably would want separate globals files, as the configurations we use for tools might be different than the ones we use for the language repos (and we may want to be able to iterate on those without having to do as much cross-pipeline testing).

displayNameFilter: $[ coalesce(variables.jobMatrixFilter, '.*') ]
pool:
name: ${{ parameters.Pool }}
Expand Down