Update stress test template to handle Scenario name and group deployments #1866
Conversation
|
The following pipelines have been queued for testing: |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| @@ -131,13 +136,13 @@ function DeployStressPackage( | |||
| $imageTag = "${registry}.azurecr.io/$($repository.ToLower())/$($imageName):$deployId" | |||
| Write-Host "Building and pushing stress test docker image '$imageTag'" | |||
| Run docker build -t $imageTag -f $dockerFile.FullName $dockerFile.DirectoryName | |||
| if ($LASTEXITCODE) { return $LASTEXITCODE } | |||
| if ($LASTEXITCODE) { return } | |||
There was a problem hiding this comment.
Do you want to make errors a no-op now?
There was a problem hiding this comment.
I realized this returned exit code isn't used anywhere. The Run function will handle adding the failures to a failures array which is then checked and reported after all stress tests have been deployed. I still want the return statements for control flow to stop execution on a per-test basis.
06a2bfe to
5dde4b0
Compare
| groupName='{{ lower .Scenario }}-{{ .Release.Name }}-{{ .Release.Revision }}' | ||
| az group create -l westus2 -g $groupName && | ||
| group=$(az group show -g $groupName -o tsv --query "id") && | ||
| az tag create --resource-id $group --tags DeleteAfter="$(date -d '+192:00:00' -Iseconds -u)" && |
There was a problem hiding this comment.
As this is growing in complexity, I plan to converge with our common deployment scripts for live tests: Azure/azure-sdk#3211
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/check-enforcer override |
This contains incremental updates to the stress-test-addons helm library:
azure-deployerdeployment model to useaz deployment groupinstead ofaz deployment subStarting as a draft PR because I'm about to go on vacation and I don't want to lose track of changes that Azure/azure-sdk-for-js#16689 is dependent on. However, there is currently a bug where the templates break if
Scenariois not specified (I think theprintffunction is causing it to evaluate despite the use ofdefault).