Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim lines for changelog content #1679

Closed
wants to merge 1 commit into from
Closed

Conversation

weshaggard
Copy link
Member

We need to trim the line to eliminate extra spaces as more importantly we need to remove any extra whitespace like line endings.

We need to trim the line to eliminate extra spaces as more importantly we need to remove any extra whitespace like line endings.
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member Author

Closing this issue as I don't know that we want to trim the lines at this level. I found the root cause of the original issue we were hitting and it is an issue in the yamldotnet library aaubry/YamlDotNet#458 where they don't serialize a multiline string using the yml multiline syntax if there are space at the end of the line before the newlines. I think instead of fixing this here we should just fix it in the code where we are doing our yml serialization.

@weshaggard weshaggard closed this Jun 9, 2021
@weshaggard weshaggard deleted the weshaggard-patch-1 branch June 21, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants