Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to force live test resources to be created in a given subscription #474

Closed
danieljurek opened this issue Apr 1, 2020 · 3 comments · Fixed by #482
Closed

Add ability to force live test resources to be created in a given subscription #474

danieljurek opened this issue Apr 1, 2020 · 3 comments · Fixed by #482
Assignees
@danieljurek
Labels
EngSys This issue is impacting the engineering system.

Comments

@danieljurek
Copy link
Member

It looks like live test resources have been getting created in the Playground subscription. We need to force these to be created in the Test Resources subscription.
@danieljurek danieljurek added the EngSys This issue is impacting the engineering system. label Apr 1, 2020
@danieljurek danieljurek self-assigned this Apr 1, 2020
@heaths
Copy link
Member

heaths commented Apr 1, 2020

I would call it -SubscriptionId for consistency. The variable group also needs to be passed the right secret value (it's using a similar - but non-existent - variable name).

@heaths
Copy link
Member

heaths commented Apr 1, 2020

Note this should also be an optional parameter, so I recommend relying on splatting to conditionally add it to Connect-AzAccount and other cmdlets as needed.

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Apr 1, 2020
@heaths
Specify subscription ID for test resources
eadb216 
Testing fix for Azure/azure-sdk-tools#474 specifically for azure-sdk-for-net repo.
@heaths heaths mentioned this issue Apr 1, 2020
Merged
heaths added a commit to Azure/azure-sdk-for-net that referenced this issue Apr 2, 2020
@heaths
Specify subscription ID for test resources (#10983)
48a7a6e 
* Specify subscription ID for test resources

Testing fix for Azure/azure-sdk-tools#474 specifically for azure-sdk-for-net repo.

* Put -SubscriptionId in right param sets
@heaths
Copy link
Member

heaths commented Apr 2, 2020

Please update this repo from my changes in Azure/azure-sdk-for-net#10983. Probably would be a good time to remove the files directly in eng/ and update the YAMLs to use the ones in eng/common.

heaths added a commit to heaths/azure-sdk-tools that referenced this issue Apr 8, 2020
@heaths
Allow subscription ID to be specified
741cd51 
Fixes Azure#474
@heaths heaths mentioned this issue Apr 8, 2020
Merged
heaths added a commit that referenced this issue Apr 8, 2020
@heaths
Allow subscription ID to be specified (#482)
b5573c2 
Fixes #474
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this issue Dec 3, 2020
@RickWinter
Remove the request id policy (Azure#474)
408f710 
* Remove the requestId policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljurek danieljurek

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow subscription ID to be specified heaths/azure-sdk-tools
2 participants
@heaths @danieljurek