-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup repo to support client generation with tsp-client #1845
Conversation
Can we pass a URL instead of local file path? Currently, we have no plans to colocate the emitter source in this repo. Can we also specify it via config? |
@hallipr can you help answer this? On the tsp-client side, I can take this into consideration for the new command that will replace the pwsh script. |
When we use New-EmitterPackageJson for separate emitter and sdk repos, it's typically the emitter repo that calls the script. The sdk repo only contains the emitter-package.json file and has no config or code related to its creation. |
Comment addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about how this should be structured but the values for the Rust emitter look correct.
This is the final shape. The only action for you is to pin your devDependencies in the typespec-rust emitter to a specific version instead of a range (otherwise you'll have to do it manually in your emitter-package.json updates). In the future you'll follow these steps to update this file with new rust emitter releases:
And of course feel free to reach out if you have any questions! |
Adding configs necessary to generate client libraries with tsp-client.
Example of how to update emitter-package.json in the future:
There will be a tsp-client specific command coming soon!
To sync the lock file with the emitter-package.json file run:
tsp-client generate-lock-file