Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread application_properties into Message within eventData #8519

Conversation

KieranBrantnerMagee
Copy link
Member

@KieranBrantnerMagee KieranBrantnerMagee commented Nov 8, 2019

This fixes a group of related issues, including this bug.

Ensures that application_properties is properly transmitted, providing the encode_data overload as well.

Update UAMQP library version

Ensure proper conversion of timeout into milliseconds for updated UAMQP version

Add a unit test to validate this test failure, and reenable the test_receive_batch_with_app_prop_sync test

Add history and increment version ID

…t is properly transmitted, providing the encode_data overload as well.

Update UAMQP library version

Ensure proper conversion of timeout into milliseconds for updated UAMQP version

Add a unit test to validate this test failure, and reenable the test_receive_batch_with_app_prop_sync test

Add history and increment version ID
@KieranBrantnerMagee KieranBrantnerMagee added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Nov 8, 2019
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Nov 8, 2019
@adxsdk6
Copy link

adxsdk6 commented Nov 8, 2019

Can one of the admins verify this patch?

@KieranBrantnerMagee KieranBrantnerMagee changed the base branch from eventhub_track1 to release/eventhub-v1 November 11, 2019 20:37
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@KieranBrantnerMagee KieranBrantnerMagee merged commit 856e4e7 into Azure:release/eventhub-v1 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants