Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-storage-blob] Policy updates + simple upload/download #6162

Merged
merged 4 commits into from
Jun 28, 2019
Merged

[azure-storage-blob] Policy updates + simple upload/download #6162

merged 4 commits into from
Jun 28, 2019

Conversation

annatisch
Copy link
Member

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Jun 28, 2019

Can one of the admins verify this patch?

@annatisch annatisch changed the title [azure-storage-blob] Policy updates [azure-storage-blob] Policy updates + simple upload/download Jun 28, 2019
@annatisch annatisch added the Storage Storage Service (Queues, Blobs, Files) label Jun 28, 2019
johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py Outdated
:rtype: dict[str, Any]
"""
with BlobClient(blob_url, credential=credential) as client:
if not overwrite and os.path.isfile(file_path):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies that we are letting the open call fail if file_path is a directory. Which also means that you will get different exception types for existing directory vs. file. Which I assume is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think letting os.path raise a specific error for an invalid path might be more informative for users then us simply telling them the path already exists.

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py
@@ -241,6 +243,27 @@ def on_response(self, request, response, **kwargs):
_LOGGER.debug("Failed to log response: %s", repr(err))


class StorageUserAgentPolicy(SansIOHTTPPolicy):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that our core UA policy takes the appropriate parameters. We should only have to specify the library name and version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - the core UA policy needs updating to reflect the latest guidelines.
For the next preview we should be able to simple use the core UA policy.
I've opened an issue here:
#6163

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py

def on_request(self, request, **kwargs):
app_string = request.context.options.pop('user_agent', None) or self._application
if app_string:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should prepend the UA string to whatever header value that was already there as opposed to completely replacing it...

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/setup.py Outdated
@@ -93,11 +93,13 @@
'tests.common'
]),
install_requires=[
#'azure-core~=0.0.1',
'azure-common~=1.1',
"azure-core>=1.0.0b1,<2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the dependency verifier in the CI system wants the order of version constraints to be swapped in order to be happy right now. Please double check with the keyvault libraries...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the analysis is passing - but will use the keyvault string anyway

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py Outdated
:type data: bytes or str or Iterable
:param bool overwrite:
Whether the blob to be uploaded should overwrite the current data.
If True, upload_blob_to_url will silently overwrite the existing data. If set to False, the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the "silently". And should it be "overwrite the current blob"? Or is this intended to indicate that properties of an existing blob will be retained? If so, I would consider explicitly stating that...

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py
:param credential:
The credentials with which to authenticate. This is optional if the
blob URL already has a SAS token. The value can be a SAS token string, an account
shared access key, or an instance of a TokenCredentials class from azure.identity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one wins if you provide both creds in the URL and as a credential parameter?

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py Outdated
:param str blob_url:
The full URI to the blob. This can also include a SAS token.
:param str file_path:
The full local path, including file name, that the blob will be downloaded to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"full local path" reads to me as if the local path has to be absolute. I assume this is not the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the argument and re-documented

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py
:returns: Blob-updated property dict (Etag and last modified)
:rtype: dict[str, Any]
"""
with BlobClient(blob_url, credential=credential) as client:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any options that would be of interest for the caller to specify? I assume not given that we allow the values to be overridden on a per method invocation basis, and thus our passing through of **kwargs takes care of anything of interest...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my thinking

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py Outdated

def download_blob_from_url(
blob_url, # type: str
file_path, # type: str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be neat to be able to provide a file-like object (e.g. StringIO) when calling the method. Which would be easy to add, but the argument name may be slightly misleading if we do. Thoughts?

johanste
johanste reviewed Jun 28, 2019
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py Outdated

def __init__(self, **kwargs):
self._application = kwargs.pop('user_agent', None)
self._user_agent = "azsdk-python-storage.blob/{} Python/{} ({})".format(
Copy link
Member

@johanste johanste Jun 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azsdk-python-storage-blob

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(replace the dot between storage and blob with a dash. The example in the general guidelines shows what it would look like for .NET. Which uses dots in their package names)

johanste
johanste approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@johanste johanste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the user agent string format is addressed, I'm good with these changes!

@annatisch annatisch merged commit 1814537 into Azure:azure-storage-blob-track2 Jun 28, 2019
annatisch added a commit that referenced this pull request Jul 2, 2019
@annatisch
Azure Storage Blob Track2 (#5896)
c93e46e 
* Storage blob track2 (#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (#5954)

* [storage-blob] Refactor shared code (#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case
annatisch added a commit that referenced this pull request Jul 2, 2019
@annatisch
[storage-file] Docs updates (#6189)
e9341e0 
* Fix failure to parse UTF8 files with BOM (#6160)

* Fix failure to parse UTF8 files with BOM

* Match frozen requirements in cosmos

* build universal wheels (#6173)

* Batch of doc

* Typo

* Update README and HISTORY of EventHub (#6151)

* Update readme

* Update sample code, obtain connection string and documentation reference in readme

* Remove import os in readme

* Added identity snippets in readme

* Update history, readme and license

* Update history

* Update history of EventHub

* Fix wrong version

* Update history of EventHub

* Update history to be more specific

* Update install command in readme for a preview version

* Update reference documentation link in readme

* don't scan anything under doc/ (#6185)

* Docs updates

* Some docs fixes

* Expand test coverage (#6170)

* Fixed model reference

* Fixed another reference

* Azure Storage Queue Track2 (#6039)

* Initial commit for Queues (#5656)

* Initial commit

* fix build

* fix build - 2

* add version

* API buildout (#5686)

* [Storage Queues] Add autorest layer to storage queues (#5687)

* add queue.json in swagger

* Add autorest layer

* Hooking up Queue client and Queue Service Client (#5817)

* Queue client

* changes

* shared access signature

* some fixes

* add tests

* Delete settings_real.py

* Refactored shared code and added tests

* Packaging update of azure-storage-queue

* Revert "Packaging update of azure-storage-queue"

This reverts commit fdc62ab.

* Add packaging overwrite

* Fixed setup

* Fixed dependency

* Storage Queues readme (#6073)

* queues readme [wip]

* small fixes

* docstrings for queues (#6066)

* Updated user-agent policy

* Updated token test

* Updated message iterator to pageable

* Renamed dequeue to receive

* Removed Py3.4 tag

* Clean pylint

* Code samples for queues (#6088)

* adds code samples for queues

* fixes to code samples and adds literalincludes for docs

* add links for TODO

* uses unicode strings for python2 compatibility

* fix readme link

* Fix CI

* [Storage Queue] pylint  + mypy pass (#6187)

* [storage-queue] Docs updates (#6186)

* Docs updates

* First round review feedback

* Adopt MSAL 0.4.1 (#6176)

* Azure Storage Blob Track2 (#5896)

* Storage blob track2 (#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (#5954)

* [storage-blob] Refactor shared code (#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case

* Updated manifest

* Renamed testcase

* Renamed samples

* Flattened tests

* Update PyPI package links on readme Key Vault (#6194)

* Renamed recordings

* fixes sample readme links (#6198)

* [azure-storage] Missing crypto dependency (#6203)

* [azure-storage] Missing crypto dependency

* Updated queue setup with crypto

* Fixed blob nspkg dependency

* Fixed queue nspkg dependency

* Added storage nspkg to shared deps

* Fixed dependencies

* Separate settings files
annatisch added a commit that referenced this pull request Jul 3, 2019
@annatisch
Azure Storage File Track2 (#6106)
1f02e1b 
* Files Skeleton (#5921)

* Generate storage files autorest layer (#5926)

* Generate autorest layer

* oops

* Rename files to file

* [Storage Files] API skeleton with helper files (#5965)

* Hookup File Service Client (#5977)

* Hookup share client (#6000)

* commit1

* Hook up Share Client

* Directory client hookup + File client  Hookup (#6040)

* file hookup

* changes

* [storage-files]Started adding files tests (#6051)

* Updated shared module

* Added tests

* First test pass

* Fixed client tests

* Fixed service props tests

* share tests (#6084)

* random commit

* share tests

* changes

* revert to fake settings

* Updates for file client tests

* Merged clients

* Fixed tests

* Recorded tests

* Clean test pass

* Packaging update of azure-storage-file

* Fixed acl test

* Fixed copy test

* More recordings

* Fixed copy recordings

* Fixed directory test

* Added close handles

* Updated packaging

* Updated user agent policy

* Updated dependencies

* Fixed handles tests

* Fixed syntax

* Files dependency conflict

* docstrings for files (#6128)

* Storage-File readme (#6156)

* adds file readme

* fix anchor for upload file

* Removed Py3.4 tag

* Clean pylint

* Fixed generated models

* Code samples for files (#6159)

* adds code samples for files

* fixes recording

* fixes code samples and adds literalincludes for docs

* fix links for readme

* Fix CI

* [storage-file] Docs updates (#6189)

* Fix failure to parse UTF8 files with BOM (#6160)

* Fix failure to parse UTF8 files with BOM

* Match frozen requirements in cosmos

* build universal wheels (#6173)

* Batch of doc

* Typo

* Update README and HISTORY of EventHub (#6151)

* Update readme

* Update sample code, obtain connection string and documentation reference in readme

* Remove import os in readme

* Added identity snippets in readme

* Update history, readme and license

* Update history

* Update history of EventHub

* Fix wrong version

* Update history of EventHub

* Update history to be more specific

* Update install command in readme for a preview version

* Update reference documentation link in readme

* don't scan anything under doc/ (#6185)

* Docs updates

* Some docs fixes

* Expand test coverage (#6170)

* Fixed model reference

* Fixed another reference

* Azure Storage Queue Track2 (#6039)

* Initial commit for Queues (#5656)

* Initial commit

* fix build

* fix build - 2

* add version

* API buildout (#5686)

* [Storage Queues] Add autorest layer to storage queues (#5687)

* add queue.json in swagger

* Add autorest layer

* Hooking up Queue client and Queue Service Client (#5817)

* Queue client

* changes

* shared access signature

* some fixes

* add tests

* Delete settings_real.py

* Refactored shared code and added tests

* Packaging update of azure-storage-queue

* Revert "Packaging update of azure-storage-queue"

This reverts commit fdc62ab.

* Add packaging overwrite

* Fixed setup

* Fixed dependency

* Storage Queues readme (#6073)

* queues readme [wip]

* small fixes

* docstrings for queues (#6066)

* Updated user-agent policy

* Updated token test

* Updated message iterator to pageable

* Renamed dequeue to receive

* Removed Py3.4 tag

* Clean pylint

* Code samples for queues (#6088)

* adds code samples for queues

* fixes to code samples and adds literalincludes for docs

* add links for TODO

* uses unicode strings for python2 compatibility

* fix readme link

* Fix CI

* [Storage Queue] pylint  + mypy pass (#6187)

* [storage-queue] Docs updates (#6186)

* Docs updates

* First round review feedback

* Adopt MSAL 0.4.1 (#6176)

* Azure Storage Blob Track2 (#5896)

* Storage blob track2 (#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (#5954)

* [storage-blob] Refactor shared code (#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case

* Updated manifest

* Renamed testcase

* Renamed samples

* Flattened tests

* Update PyPI package links on readme Key Vault (#6194)

* Renamed recordings

* fixes sample readme links (#6198)

* [azure-storage] Missing crypto dependency (#6203)

* [azure-storage] Missing crypto dependency

* Updated queue setup with crypto

* Fixed blob nspkg dependency

* Fixed queue nspkg dependency

* Added storage nspkg to shared deps

* Fixed dependencies

* Separate settings files

* [Storage File] pylint + mypy pass (#6202)
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
@annatisch @rajivnandivada
Azure Storage Blob Track2 (Azure#5896)
d394ac8 
* Storage blob track2 (Azure#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (Azure#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (Azure#5954)

* [storage-blob] Refactor shared code (Azure#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (Azure#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (Azure#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (Azure#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (Azure#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (Azure#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (Azure#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
@annatisch @rajivnandivada
Azure Storage File Track2 (Azure#6106)
5b709c7 
* Files Skeleton (Azure#5921)

* Generate storage files autorest layer (Azure#5926)

* Generate autorest layer

* oops

* Rename files to file

* [Storage Files] API skeleton with helper files (Azure#5965)

* Hookup File Service Client (Azure#5977)

* Hookup share client (Azure#6000)

* commit1

* Hook up Share Client

* Directory client hookup + File client  Hookup (Azure#6040)

* file hookup

* changes

* [storage-files]Started adding files tests (Azure#6051)

* Updated shared module

* Added tests

* First test pass

* Fixed client tests

* Fixed service props tests

* share tests (Azure#6084)

* random commit

* share tests

* changes

* revert to fake settings

* Updates for file client tests

* Merged clients

* Fixed tests

* Recorded tests

* Clean test pass

* Packaging update of azure-storage-file

* Fixed acl test

* Fixed copy test

* More recordings

* Fixed copy recordings

* Fixed directory test

* Added close handles

* Updated packaging

* Updated user agent policy

* Updated dependencies

* Fixed handles tests

* Fixed syntax

* Files dependency conflict

* docstrings for files (Azure#6128)

* Storage-File readme (Azure#6156)

* adds file readme

* fix anchor for upload file

* Removed Py3.4 tag

* Clean pylint

* Fixed generated models

* Code samples for files (Azure#6159)

* adds code samples for files

* fixes recording

* fixes code samples and adds literalincludes for docs

* fix links for readme

* Fix CI

* [storage-file] Docs updates (Azure#6189)

* Fix failure to parse UTF8 files with BOM (Azure#6160)

* Fix failure to parse UTF8 files with BOM

* Match frozen requirements in cosmos

* build universal wheels (Azure#6173)

* Batch of doc

* Typo

* Update README and HISTORY of EventHub (Azure#6151)

* Update readme

* Update sample code, obtain connection string and documentation reference in readme

* Remove import os in readme

* Added identity snippets in readme

* Update history, readme and license

* Update history

* Update history of EventHub

* Fix wrong version

* Update history of EventHub

* Update history to be more specific

* Update install command in readme for a preview version

* Update reference documentation link in readme

* don't scan anything under doc/ (Azure#6185)

* Docs updates

* Some docs fixes

* Expand test coverage (Azure#6170)

* Fixed model reference

* Fixed another reference

* Azure Storage Queue Track2 (Azure#6039)

* Initial commit for Queues (Azure#5656)

* Initial commit

* fix build

* fix build - 2

* add version

* API buildout (Azure#5686)

* [Storage Queues] Add autorest layer to storage queues (Azure#5687)

* add queue.json in swagger

* Add autorest layer

* Hooking up Queue client and Queue Service Client (Azure#5817)

* Queue client

* changes

* shared access signature

* some fixes

* add tests

* Delete settings_real.py

* Refactored shared code and added tests

* Packaging update of azure-storage-queue

* Revert "Packaging update of azure-storage-queue"

This reverts commit fdc62ab.

* Add packaging overwrite

* Fixed setup

* Fixed dependency

* Storage Queues readme (Azure#6073)

* queues readme [wip]

* small fixes

* docstrings for queues (Azure#6066)

* Updated user-agent policy

* Updated token test

* Updated message iterator to pageable

* Renamed dequeue to receive

* Removed Py3.4 tag

* Clean pylint

* Code samples for queues (Azure#6088)

* adds code samples for queues

* fixes to code samples and adds literalincludes for docs

* add links for TODO

* uses unicode strings for python2 compatibility

* fix readme link

* Fix CI

* [Storage Queue] pylint  + mypy pass (Azure#6187)

* [storage-queue] Docs updates (Azure#6186)

* Docs updates

* First round review feedback

* Adopt MSAL 0.4.1 (Azure#6176)

* Azure Storage Blob Track2 (Azure#5896)

* Storage blob track2 (Azure#5894)

* Blob storage track 2

* Started pylint fixes

* Clean pylint

* Started blob walk

* Started docstrings

* Support walk blob

* Pylint

* Refactored upload

* Pylint

* Packaging update of azure-storage-blob

* Fixes to storage dependencies in CI (Azure#5900)

* Revert "Packaging update of azure-storage-blob"

This reverts commit aeeb3ce.

* Fix Storage CI

* Fixed imports

* updating ccount_key_arg -> account_key_arg

* updating ordering

* Packaging update of azure-storage-blob

* Revert "Packaging update of azure-storage-blob"

This reverts commit 66d6877.

* reverting 66d6877. adding sdk_packaging.toml file

* docstrings for blobs (Azure#5954)

* [storage-blob] Refactor shared code (Azure#5960)

* Fix Storage CI

* Fixed imports

* Refactor shared storage code

* Fixed XML error

* Reverted change to models

* Merged models docstrings

* Fix setup.py version

* Missing recordings

* Fix storage SDK conflict

* Packaging update of azure-eventhubs

* Revert "Packaging update of azure-eventhubs"

This reverts commit df844f7.

* Fix EH packaging

* Updated shared code

* Review feedback

* [azure-storage-blob] Policy updates + simple upload/download (Azure#6162)

* Last blob updates

* Azure core dependency version

* Update to user-agent policy

* Review feedback

* Removed old python tags

* Code samples for blobs (Azure#6093)

* adds code samples for blobs

* fixes blob code samples and adds literalincludes for docs

* Storage Blobs Readme [wip] (Azure#6011)

* blobs readme wip

* adding some samples and fixes for readme

* fix settings import

* moving code samples to a different PR

* small fixes to readme

* fill links for pypi and identity

* populating TODO links

* Fix CI

* [Storage Blob] pylint + mypy passs (Azure#6175)

* pylint + mypy passs

* comments

* [storage-blob] Docs updates (Azure#6184)

* Docs updates

* Some docstring fixes

* [storage-blob] Test rename (Azure#6197)

* Test rename

* Removed test init files

* More renames

* Try flattening tests

* Blob test imports

* Flattened queue tests

* Renamed queue test case

* Updated manifest

* Renamed testcase

* Renamed samples

* Flattened tests

* Update PyPI package links on readme Key Vault (Azure#6194)

* Renamed recordings

* fixes sample readme links (Azure#6198)

* [azure-storage] Missing crypto dependency (Azure#6203)

* [azure-storage] Missing crypto dependency

* Updated queue setup with crypto

* Fixed blob nspkg dependency

* Fixed queue nspkg dependency

* Added storage nspkg to shared deps

* Fixed dependencies

* Separate settings files

* [Storage File] pylint + mypy pass (Azure#6202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanste johanste johanste approved these changes

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annatisch @adxsdk6 @johanste