Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-core] Fixes 'no retries' config in retry policy #5803

Merged
merged 5 commits into from
Jun 12, 2019

Conversation

kristapratico
Copy link
Member

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Jun 11, 2019

Can one of the admins verify this patch?

@bryevdv
Copy link
Contributor

bryevdv commented Jun 11, 2019

Can we add a basic test to exercise basic instance creation with no_retries Relying on kwargs popping makes its easier for a silent failure like this to pop up in one place when there is a change in another.

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me the no_retries method requires an input but in our samples, there is no input. Please double check.

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline

@kristapratico kristapratico merged commit 88eb9bb into Azure:master Jun 12, 2019
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
* fixes no retries config

* adds a no retries test
@kristapratico kristapratico deleted the issue5802 branch July 5, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants