-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added isinstance checks to fix tox pyright errors #39780
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7d33c12
added isinstance checks tox pyright errors
chrisribe 2917b53
Bump version and changelog for pyright fix
chrisribe 4091229
Making sure testenv uses typing_extensions 4.12.0
chrisribe 5c8959f
Revert "Making sure testenv uses typing_extensions 4.12.0"
chrisribe 8dd84b1
ForwardRef fix via getattr
chrisribe 8d05d82
fix mypy errors
chrisribe 3f4241b
rem trailing whitespaces
chrisribe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
sdk/healthdataaiservices/azure-health-deidentification/CHANGELOG.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given these typing errors arise from the generated code, it is up to the code generator to fix them. We test our code generator against the latest versions of the type checkers we run, so it should generate type clean code for each client library. It looks like this library was last generated ~7 months ago. I suspect if we regenerate the code with the latest version of the generator that these errors will be cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kristapratico for your comment. It prompted me to review the documentation again. I found it odd that I needed to modify these files, as the comments didn't indicate they were auto-generated.
I now understand that these files need to be rebuilt locally using the tsp-client and the latest azure-rest-api-specs for our project. As you mentioned, this hasn't been done in the last ~7 months, and I just picked this up. Apologies for the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok seems I am stepping on toes here and a PR is already in review:
#38437
Dropping this PR request.
Sorry for the bother.