Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number Insight GA #38793

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

guoqing2023
Copy link
Member

@guoqing2023 guoqing2023 commented Dec 6, 2024

Description

Update azure-communication-phonenumbers SDK to transit from our previous preview version to a fully supported GA version.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • This will be coming in a subsequent version, this is just for review, the service is not deployed with these changes so tests will not succeed currently

Packages impacted by this PR

@azure/communication-phone-numbers

Issues associated with this PR: https://skype.visualstudio.com/SPOOL/_workitems/edit/3994015/?view=edit

Provide a list of related PRs (if any)

API Specs: Azure/azure-rest-api-specs#31978
.net: Azure/azure-sdk-for-net#47195
Java: Azure/azure-sdk-for-java#43290
Python: #38793
JavaScript: Azure/azure-sdk-for-js#32095

APIView:

API Specs: https://apiview.dev/Assemblies/Review/ba16371e7b7e46b79b9be65fa0119ccd?revisionId=484ad4a29e054ee1be1df31c6c45e2ba&diffOnly=False&doc=False&diffRevisionId=ba31920ba63c477597d96aded7f0e320
.net: https://spa.apiview.dev/review/e465f73b881e41a5875a9d614a96d3ad?activeApiRevisionId=ccea565c3a4542deacc389de5ca77f2d&diffApiRevisionId=26571e2b0fda4ccd88cf379b9cb06f61
Java: https://apiview.dev/Assemblies/Review/ef288c648931473f8ac61a2248b90b1a?revisionId=d2a2455731bd45b48e472cb0609352fb&diffOnly=False&doc=False&diffRevisionId=ce79f52fc3b64f2ab3e4329e49c5e3f2
Python: API changes are not detected in this pull request.
JavaScript: https://spa.apiview.dev/review/ec5503f48f0b42cdbbb2e6bd4ec0aa87?activeApiRevisionId=88cf3f64633b493eb88ef9db82ab425b&diffApiRevisionId=553e954e8cf34d79a9f4e67c6b649416

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 6, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-phonenumbers

@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch 2 times, most recently from 0c3816d to fd75edb Compare December 7, 2024 03:33
@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch from fd75edb to 9384a78 Compare December 28, 2024 01:28
@guoqing2023 guoqing2023 changed the title Work In Progress WIP: Add ChangeLog WIP: Number Insight GA Dec 28, 2024
@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch from 58b6b4f to ddd8353 Compare January 16, 2025 23:52
@guoqing2023 guoqing2023 force-pushed the guoqing/number-insight-ga branch from 26e61a5 to fe64431 Compare January 17, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants