Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure AI Face SDK beta2 #37044

Merged
merged 31 commits into from
Oct 22, 2024
Merged

Azure AI Face SDK beta2 #37044

merged 31 commits into from
Oct 22, 2024

Conversation

Han-msft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Face label Aug 27, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-vision-face

@Han-msft Han-msft changed the title Azure AI Face SDK v1.1 Azure AI Face SDK beta2 Sep 2, 2024
@Han-msft Han-msft marked this pull request as ready for review September 9, 2024 02:56
@Han-msft Han-msft requested a review from zihyunting as a code owner September 9, 2024 02:56
This was referenced Sep 9, 2024
Closed
Closed
@msyyc
Copy link
Member

msyyc commented Sep 9, 2024

Will try to fix pylint issue before the PR merge:
Azure/autorest.python#2817
Azure/autorest.python#2800

@msyyc
Copy link
Member

msyyc commented Sep 25, 2024

https://dev.azure.com/azure-sdk/public/_build/results?buildId=4164022&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=e3f8f308-6e5f-58aa-3a2a-fe425958de32
@Han-msft Please update _patch.py to fix the mypy/pyright error.

@msyyc msyyc merged commit 8d6a26c into main Oct 22, 2024
21 checks passed
@msyyc msyyc deleted the hachiang/face-v1.1 branch October 22, 2024 06:35
This was referenced Oct 30, 2024
Merged
Merged
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@Han-msft @l0lawrence
Azure AI Face SDK beta2 (Azure#37044)
ecba769 
* codegen update

* Update client _patch

* Update version

* Update assets

* Update codegen

* Sample for large face list

* Add LPG sample

* Update codegen

* Remove unused testcase

* Add findsimilar test

* Add identify test

* Remove FL and PG

* Fix test

* Update codegen

* Remove _operations

* Add changelog

* Codegen

* Add new content to README

* Regen

* Update model enum

* Update typo in generated test

* Add enum breaking change schangelog

* update codegen

* Fix customization

* Suppress verifytypes

* Update to latest tsp

* Pause verifytypes

* Update release date

* Update date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyyc msyyc msyyc approved these changes

@zihyunting zihyunting Awaiting requested review from zihyunting zihyunting is a code owner

Assignees
No one assigned
Labels
Face
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Han-msft @azure-sdk @msyyc