Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR compute/resource-manager] Update VMSS planned maintenance description to refer to best practices doc #2911

Merged
merged 2 commits into from
Jul 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1462,6 +1462,9 @@ def _perform_maintenance_initial(
def perform_maintenance(
self, resource_group_name, vm_scale_set_name, instance_ids=None, custom_headers=None, raw=False, polling=True, **operation_config):
"""Perform maintenance on one or more virtual machines in a VM scale set.
Operation on instances which are not eligible for perform maintenance
will be failed. Please refer to best practices for more details:
https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-maintenance-notifications.

:param resource_group_name: The name of the resource group.
:type resource_group_name: str
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1364,6 +1364,9 @@ def _perform_maintenance_initial(
def perform_maintenance(
self, resource_group_name, vm_scale_set_name, instance_ids=None, custom_headers=None, raw=False, polling=True, **operation_config):
"""Perform maintenance on one or more virtual machines in a VM scale set.
Operation on instances which are not eligible for perform maintenance
will be failed. Please refer to best practices for more details:
https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-maintenance-notifications.

:param resource_group_name: The name of the resource group.
:type resource_group_name: str
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ class VirtualMachineScaleSetIPConfiguration(SubResource):
Multiple scale sets cannot use the same application gateway.
:type application_gateway_backend_address_pools:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param application_security_groups: Specifies an array of references to
application security group.
:type application_security_groups:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param load_balancer_backend_address_pools: Specifies an array of
references to backend address pools of load balancers. A scale set can
reference backend address pools of one public and one internal load
Expand All @@ -67,6 +71,7 @@ class VirtualMachineScaleSetIPConfiguration(SubResource):
'public_ip_address_configuration': {'key': 'properties.publicIPAddressConfiguration', 'type': 'VirtualMachineScaleSetPublicIPAddressConfiguration'},
'private_ip_address_version': {'key': 'properties.privateIPAddressVersion', 'type': 'str'},
'application_gateway_backend_address_pools': {'key': 'properties.applicationGatewayBackendAddressPools', 'type': '[SubResource]'},
'application_security_groups': {'key': 'properties.applicationSecurityGroups', 'type': '[SubResource]'},
'load_balancer_backend_address_pools': {'key': 'properties.loadBalancerBackendAddressPools', 'type': '[SubResource]'},
'load_balancer_inbound_nat_pools': {'key': 'properties.loadBalancerInboundNatPools', 'type': '[SubResource]'},
}
Expand All @@ -79,5 +84,6 @@ def __init__(self, **kwargs):
self.public_ip_address_configuration = kwargs.get('public_ip_address_configuration', None)
self.private_ip_address_version = kwargs.get('private_ip_address_version', None)
self.application_gateway_backend_address_pools = kwargs.get('application_gateway_backend_address_pools', None)
self.application_security_groups = kwargs.get('application_security_groups', None)
self.load_balancer_backend_address_pools = kwargs.get('load_balancer_backend_address_pools', None)
self.load_balancer_inbound_nat_pools = kwargs.get('load_balancer_inbound_nat_pools', None)
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ class VirtualMachineScaleSetIPConfiguration(SubResource):
Multiple scale sets cannot use the same application gateway.
:type application_gateway_backend_address_pools:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param application_security_groups: Specifies an array of references to
application security group.
:type application_security_groups:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param load_balancer_backend_address_pools: Specifies an array of
references to backend address pools of load balancers. A scale set can
reference backend address pools of one public and one internal load
Expand All @@ -67,17 +71,19 @@ class VirtualMachineScaleSetIPConfiguration(SubResource):
'public_ip_address_configuration': {'key': 'properties.publicIPAddressConfiguration', 'type': 'VirtualMachineScaleSetPublicIPAddressConfiguration'},
'private_ip_address_version': {'key': 'properties.privateIPAddressVersion', 'type': 'str'},
'application_gateway_backend_address_pools': {'key': 'properties.applicationGatewayBackendAddressPools', 'type': '[SubResource]'},
'application_security_groups': {'key': 'properties.applicationSecurityGroups', 'type': '[SubResource]'},
'load_balancer_backend_address_pools': {'key': 'properties.loadBalancerBackendAddressPools', 'type': '[SubResource]'},
'load_balancer_inbound_nat_pools': {'key': 'properties.loadBalancerInboundNatPools', 'type': '[SubResource]'},
}

def __init__(self, *, name: str, id: str=None, subnet=None, primary: bool=None, public_ip_address_configuration=None, private_ip_address_version=None, application_gateway_backend_address_pools=None, load_balancer_backend_address_pools=None, load_balancer_inbound_nat_pools=None, **kwargs) -> None:
def __init__(self, *, name: str, id: str=None, subnet=None, primary: bool=None, public_ip_address_configuration=None, private_ip_address_version=None, application_gateway_backend_address_pools=None, application_security_groups=None, load_balancer_backend_address_pools=None, load_balancer_inbound_nat_pools=None, **kwargs) -> None:
super(VirtualMachineScaleSetIPConfiguration, self).__init__(id=id, **kwargs)
self.name = name
self.subnet = subnet
self.primary = primary
self.public_ip_address_configuration = public_ip_address_configuration
self.private_ip_address_version = private_ip_address_version
self.application_gateway_backend_address_pools = application_gateway_backend_address_pools
self.application_security_groups = application_security_groups
self.load_balancer_backend_address_pools = load_balancer_backend_address_pools
self.load_balancer_inbound_nat_pools = load_balancer_inbound_nat_pools
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ class VirtualMachineScaleSetUpdateIPConfiguration(SubResource):
backend address pools.
:type application_gateway_backend_address_pools:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param application_security_groups: Specifies an array of references to
application security group.
:type application_security_groups:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param load_balancer_backend_address_pools: The load balancer backend
address pools.
:type load_balancer_backend_address_pools:
Expand All @@ -55,6 +59,7 @@ class VirtualMachineScaleSetUpdateIPConfiguration(SubResource):
'public_ip_address_configuration': {'key': 'properties.publicIPAddressConfiguration', 'type': 'VirtualMachineScaleSetUpdatePublicIPAddressConfiguration'},
'private_ip_address_version': {'key': 'properties.privateIPAddressVersion', 'type': 'str'},
'application_gateway_backend_address_pools': {'key': 'properties.applicationGatewayBackendAddressPools', 'type': '[SubResource]'},
'application_security_groups': {'key': 'properties.applicationSecurityGroups', 'type': '[SubResource]'},
'load_balancer_backend_address_pools': {'key': 'properties.loadBalancerBackendAddressPools', 'type': '[SubResource]'},
'load_balancer_inbound_nat_pools': {'key': 'properties.loadBalancerInboundNatPools', 'type': '[SubResource]'},
}
Expand All @@ -67,5 +72,6 @@ def __init__(self, **kwargs):
self.public_ip_address_configuration = kwargs.get('public_ip_address_configuration', None)
self.private_ip_address_version = kwargs.get('private_ip_address_version', None)
self.application_gateway_backend_address_pools = kwargs.get('application_gateway_backend_address_pools', None)
self.application_security_groups = kwargs.get('application_security_groups', None)
self.load_balancer_backend_address_pools = kwargs.get('load_balancer_backend_address_pools', None)
self.load_balancer_inbound_nat_pools = kwargs.get('load_balancer_inbound_nat_pools', None)
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ class VirtualMachineScaleSetUpdateIPConfiguration(SubResource):
backend address pools.
:type application_gateway_backend_address_pools:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param application_security_groups: Specifies an array of references to
application security group.
:type application_security_groups:
list[~azure.mgmt.compute.v2018_06_01.models.SubResource]
:param load_balancer_backend_address_pools: The load balancer backend
address pools.
:type load_balancer_backend_address_pools:
Expand All @@ -55,17 +59,19 @@ class VirtualMachineScaleSetUpdateIPConfiguration(SubResource):
'public_ip_address_configuration': {'key': 'properties.publicIPAddressConfiguration', 'type': 'VirtualMachineScaleSetUpdatePublicIPAddressConfiguration'},
'private_ip_address_version': {'key': 'properties.privateIPAddressVersion', 'type': 'str'},
'application_gateway_backend_address_pools': {'key': 'properties.applicationGatewayBackendAddressPools', 'type': '[SubResource]'},
'application_security_groups': {'key': 'properties.applicationSecurityGroups', 'type': '[SubResource]'},
'load_balancer_backend_address_pools': {'key': 'properties.loadBalancerBackendAddressPools', 'type': '[SubResource]'},
'load_balancer_inbound_nat_pools': {'key': 'properties.loadBalancerInboundNatPools', 'type': '[SubResource]'},
}

def __init__(self, *, id: str=None, name: str=None, subnet=None, primary: bool=None, public_ip_address_configuration=None, private_ip_address_version=None, application_gateway_backend_address_pools=None, load_balancer_backend_address_pools=None, load_balancer_inbound_nat_pools=None, **kwargs) -> None:
def __init__(self, *, id: str=None, name: str=None, subnet=None, primary: bool=None, public_ip_address_configuration=None, private_ip_address_version=None, application_gateway_backend_address_pools=None, application_security_groups=None, load_balancer_backend_address_pools=None, load_balancer_inbound_nat_pools=None, **kwargs) -> None:
super(VirtualMachineScaleSetUpdateIPConfiguration, self).__init__(id=id, **kwargs)
self.name = name
self.subnet = subnet
self.primary = primary
self.public_ip_address_configuration = public_ip_address_configuration
self.private_ip_address_version = private_ip_address_version
self.application_gateway_backend_address_pools = application_gateway_backend_address_pools
self.application_security_groups = application_security_groups
self.load_balancer_backend_address_pools = load_balancer_backend_address_pools
self.load_balancer_inbound_nat_pools = load_balancer_inbound_nat_pools