Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] reservations/resource-manager #2695

Merged
merged 4 commits into from
Jun 12, 2018

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: reservations/resource-manager

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jun 6, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-reservations

You can install the package azure-mgmt-reservations of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_reservations/resource-manager#egg=azure-mgmt-reservations&subdirectory=azure-mgmt-reservations"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_reservations/resource-manager#egg=azure-mgmt-reservations&subdirectory=azure-mgmt-reservations"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_reservations/resource-manager
  • pip install -e ./azure-mgmt-reservations

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_reservations/resource-manager
  • pip wheel --no-deps ./azure-mgmt-reservations

Direct download

Your files can be directly downloaded here:

@lmazuel
Copy link
Member

lmazuel commented Jun 8, 2018

@AutorestCI rebase

…cs (#2658)

* Generated from d5741e93743ec8a4a11072e2dcf61aa25c231070

copying all changes from private repo for 2018-06-01

* Generated from afb41ac0cf762818aeade34545af669b00fb9fd6

Update readme.md

* Generated from 324d0b9ba69e3d170c9ad9a23e4fa51648537f63

renaming autoFit to instanceFlexibility and its enum values
@AutorestCI AutorestCI force-pushed the restapi_auto_reservations/resource-manager branch from b67f007 to f8ec615 Compare June 8, 2018 18:07
@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #2695 into master will increase coverage by 0.08%.
The diff coverage is 95.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
+ Coverage   55.89%   55.97%   +0.08%     
==========================================
  Files        7213     7332     +119     
  Lines      151649   154500    +2851     
==========================================
+ Hits        84767    86488    +1721     
- Misses      66882    68012    +1130
Impacted Files Coverage Δ
...ons/azure/mgmt/reservations/operations/__init__.py 100% <ø> (ø) ⬆️
.../reservations/models/reservation_response_paged.py 100% <ø> (ø) ⬆️
...vations/models/reservation_order_response_paged.py 100% <ø> (ø) ⬆️
...t-reservations/azure/mgmt/reservations/__init__.py 100% <ø> (ø) ⬆️
...mt/reservations/models/operation_response_paged.py 100% <ø> (ø) ⬆️
...ns/azure/mgmt/reservations/models/split_request.py 100% <100%> (ø) ⬆️
...vations/models/reservation_merge_properties_py3.py 100% <100%> (ø)
...mt/reservations/models/applied_reservations_py3.py 100% <100%> (ø)
...rvations/azure/mgmt/reservations/models/catalog.py 100% <100%> (ø) ⬆️
...mt/reservations/models/reservation_response_py3.py 100% <100%> (ø)
... and 211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6d5da...fe87f28. Read the comment docs.

@juhee0202
Copy link

juhee0202 commented Jun 12, 2018

@lmazuel

Changes in 0.2.0

Notes

  • Changed Update Reservation API
    • Added optional InstanceFlexibility parameter
  • Support for InstanceFlexibility
  • Support for ReservedResourceType (VirtualMachines, SqlDatabases, SuseLinux)
  • Upgrade to rest api version 2018-06-01

Breaking change

  • Updated Get Catalog API
    • Added required parameter 'reserved_resource_type'
    • Added optional parameter 'location'
  • Updated Catalog model
    • Renamed property 'capabilities' to 'sku_properties'
    • Removed properties 'size' and 'tier'
  • Updated ReservationProperties model
    • Removed property 'kind'

@lmazuel lmazuel merged commit 9a3e715 into master Jun 12, 2018
@lmazuel lmazuel deleted the restapi_auto_reservations/resource-manager branch June 12, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants