-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.6 deprecated #25768
Python 3.6 deprecated #25768
Conversation
Thank you for your contribution JJHWAN! We will review the pull request and get back to you soon. |
I also checked, it seems to have deleted everything written in version 3.6 or lower in service bus. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JJHWAN - Thanks for opening a PR! I left a few comments. Once you address them, I can take another look. 🙂
sdk/servicebus/azure-servicebus/stress/scripts/dev_requirements.txt
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/swagger/generate_attributes_sequence_tuple.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/swagger/generate_attributes_sequence_tuple.py
Outdated
Show resolved
Hide resolved
Thanks for the review I will make changes as you replied :) |
890de75
to
a8e57ee
Compare
Changes with the Review was applied
a8e57ee
to
6bd884e
Compare
@swathipil I made changes as you said, Can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @JJHWAN!
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
# Description fixed Azure#25148 Updating service bus python requirement from 3.6 to 3.7
AKS Fleet 2023 10 15 (Azure#25768) * rebase * rebase * rebase * rebase * rebase * rebase * rebase * [Fleet] Fix readme.md for 0815 (Azure#25822) * fix readme * format * remove hub profile * examples * fixed example * fix example * fix readme * rebase * suppress versioning error * compile
Description
fixed #25148
Updating service bus python requirement from 3.6 to 3.7