Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] fix spelling according to cspell #22858

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

kristapratico
Copy link
Member

Resolves #22684

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kristapratico kristapratico merged commit b76aab1 into Azure:main Feb 1, 2022
@kristapratico kristapratico deleted the dt-cspell branch February 1, 2022 19:33
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. One small recommendation.

@@ -550,6 +550,6 @@ def test_translation_with_glossary(self, client):

with open(document, "rb") as fd:
translated = fd.readline()

# cSpell:ignore essai
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using an override like this in the config so we don't couple our source code to the cspell tool.

    ...
    "overrides": [
      {
        "filename": "sdk/translation/azure-ai-translation-document/tests/*.py",
        "words": [
          "essai"
        ]
      },
      ...
    ]...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - thanks. I somehow missed that way of ignoring while reading the docs. Opened a PR to fix here: #22865

rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

translation/azure-ai-translation-document - cspell found spelling errors in source code
4 participants