-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[translation] fix spelling according to cspell #22858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. One small recommendation.
@@ -550,6 +550,6 @@ def test_translation_with_glossary(self, client): | |||
|
|||
with open(document, "rb") as fd: | |||
translated = fd.readline() | |||
|
|||
# cSpell:ignore essai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using an override like this in the config so we don't couple our source code to the cspell
tool.
...
"overrides": [
{
"filename": "sdk/translation/azure-ai-translation-document/tests/*.py",
"words": [
"essai"
]
},
...
]...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - thanks. I somehow missed that way of ignoring while reading the docs. Opened a PR to fix here: #22865
Resolves #22684