Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Match the partition key with session id only when both are set #18955

Closed
wants to merge 0 commits into from

Conversation

bishnu-shb
Copy link
Contributor

The azure documentation says "if a message has the partition key property but not the session ID property set, then Service Bus uses the partition key property value as the partition key. If the message has both the session ID and the partition key properties set, both properties must be identical" [https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-partitioning#using-a-partition-key].

@ghost ghost added Service Bus customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 26, 2021
@ghost
Copy link

ghost commented May 26, 2021

Thank you for your contribution bishnu-shb! We will review the pull request and get back to you soon.

@yunhaoling
Copy link
Contributor

@bishnu-shb, thanks for your PR! we'll take a look ASAP

@yunhaoling
Copy link
Contributor

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil self-assigned this Jun 10, 2021
@swathipil swathipil added this to the [2021] July milestone Jun 10, 2021
@swathipil swathipil closed this Jun 10, 2021
@swathipil
Copy link
Member

Hi @bishnu-shb,

I was in the middle of changing some failing tests to pass with your change. However, I accidentally pushed without pulling your changes and this closed the PR. I am no longer able to make changes to this PR. Would you be able to create a new PR with the same change (adding and self.session_id check to the ServiceBus partition_key property)?

Thank you for your patience!

@bishnu-shb
Copy link
Contributor Author

Created #19233

ghost pushed a commit that referenced this pull request Jun 22, 2021
…re set (#19233)

The azure documentation says "if a message has the partition key property but not the session ID property set, then Service Bus uses the partition key property value as the partition key. If the message has both the session ID and the partition key properties set, both properties must be identical" [https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-partitioning#using-a-partition-key]. 
[Re-raised #18955]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants