Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formrecognizer] adjust text angle to fit in specified interval #12248

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

kristapratico
Copy link
Member

based on Teams chat discussion

@kristapratico kristapratico self-assigned this Jun 29, 2020
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Jun 29, 2020
iscai-msft
iscai-msft previously approved these changes Jun 29, 2020
Comment on lines 167 to 168
if actual_page.angle < 180:
self.assertEqual(page.text_angle, actual_page.angle)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be <= here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch :)

@kristapratico kristapratico merged commit 83ac5e9 into Azure:master Jun 30, 2020
@kristapratico kristapratico deleted the textangle branch June 30, 2020 16:52
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 30, 2020
…into regenerate_secrets

* 'master' of https://github.com/Azure/azure-sdk-for-python: (36 commits)
  Install dev dependency when running apistub (Azure#12268)
  SharedTokenCacheCredential lazily loads the cache (Azure#12172)
  Changes in docs [Form Recognizer] (Azure#12216)
  [formrecognizer] adjust text angle to fit in specified interval (Azure#12248)
  Set http_logging_policy in Configuration (Azure#12218)
  Sync eng/common directory with azure-sdk-tools repository (Azure#11990)
  AzureCliCredential instructs CLI not to color output (Azure#11362)
  Sdk automation/track2 azure mgmt storage (Azure#12238)
  Fix changelog of CustomVision (Azure#12225)
  Doc update for conf file name (Azure#12224)
  update doc for content_type (Azure#12220)
  update API version to use 2020-06-30 (Azure#12208)
  Use MSAL's custom transport API (Azure#11892)
  add breadcumbs for training filter (Azure#12196)
  [formrecognizer] arch board feedback renames (Azure#12207)
  Dataplane autogeneration (Azure#12210)
  update version number and API_version support (Azure#12154)
  Update SECURITY.md (Azure#12209)
  adding a pip freeze to ensure we fully understand what our environment has (Azure#12173)
  FaceAPI 0.4.1 (Azure#12199)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants